Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: fix race in heartbeat tracker #14119

Merged
merged 1 commit into from
Aug 16, 2022
Merged

client: fix race in heartbeat tracker #14119

merged 1 commit into from
Aug 16, 2022

Conversation

schmichael
Copy link
Member

Part 1/n of my effort to make agent tests race free.

@schmichael schmichael mentioned this pull request Aug 15, 2022
Merged
DerekStrickland
DerekStrickland approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@DerekStrickland DerekStrickland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Did you mean to assign this to us, or just add us as reviewers?

tgross
tgross approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@schmichael
Copy link
Member Author

+1

Did you mean to assign this to us, or just add us as reviewers?

🤦 Sometimes I click the wrong buttons

@schmichael schmichael merged commit fc2ebe1 into main Aug 16, 2022
@schmichael schmichael deleted the b-race-heartbeat branch August 16, 2022 16:41
@schmichael schmichael added this to the 1.4.0 milestone Aug 18, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tgross tgross tgross approved these changes

@DerekStrickland DerekStrickland DerekStrickland approved these changes

Assignees

@DerekStrickland DerekStrickland

@tgross tgross

Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@schmichael @DerekStrickland @tgross