-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parameterized job child meta/payload UI #11954
Conversation
Previously the metadata UI bit for parameterized children was completely broken. Also splits the payload component out into a separate template.
Thanks for the PR @alistairking! The meta change makes sense to me, but I'm not sure why the payload is broken. I think it may have happened during #11780 so I will ask @ChaiWithJai to take a look. |
@lgfa29 @ChaiWithJai any updates on this one? |
@alistairking no updates yet, but we have it set for the next release 🙂 |
Hi @alistairking, thanks for this PR. The fix in #13473 should bring the Meta and Payload sections back to parameterized child jobs, and is being backported to Nomad 1.3.x releases. I'll close out this PR as such, and thanks so much for helping us identify the issue! |
thanks! |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Disclaimer: I don't know anything about UI things.
This seems to work for me, but I'm sure there are better ways to make this fix.
Test Job
Metadata
Previously the metadata UI bit for parameterized children was completely broken. Even jobs that did have metadata would appear to have none.
It seems that the
<jobPage.ui.Meta />
component already handles non-existent metadata, so I simply dropped the (broken) checking for no metadata.Before:
After
Payload
I think something has broken recently with https://github.com/hashicorp/nomad/blob/main/ui/app/components/job-page/parameterized-child.js such that those
payload
andpayloadJSON
attributes aren't working, but I couldn't figure out how to fix it which is why I copied the payloadJSON method into the job model -- if someone smarter than me could help me fix this properly that would be great.