fix: authorization bug for job-client-status-summary
#11780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember Asset Size actionAs of 8d8fe0b Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
There was previously a bug with sourceMaps that slowed down the build. This issue has been resolved by Ember and now we can expect the default behavior of sourceMaps being enabled in dev and disabled in prod.
…nd param-child to use Glimmer
Previously, the router service was not available to components. Now that it is, we no longer need to prop-drill this linking action.
ChaiWithJai
force-pushed
the
f-ui/job-page-refactor
branch
from
f2df422 to
6c65966
Compare
LevelbossMike
suggested changes
Jan 26, 2022
| @@ -217,3 +227,13 @@ module('Acceptance | job clients', function (hooks) { | |||
| // TODO: add facet tests for actual list filtering | |||
| } | |||
| }); | |||
|
|
|||
| function setPolicy(policy) { | |||
There was a problem hiding this comment.
We are repeating ourselves here, ui/tests/helpers/module-for-job.js and ui/tests/acceptance/job-clients-test.js are both defining this function - we should extract that into a test-utility.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles an unexpected authorization failure when in a
systemorsysbatchpage withoutnode:readpermissions.This PR closes 11660.
This PR handles the concerns of 11672.