Remove API duplicates of nomad/structs and remove the compose api.

[dadgar]

The api package has copies of the nomad structs used everywhere else. We should just remove them (example

nomad/api/jobs.go

Line 111 in fd3dcce

type Job struct {

) and also the compose helpers (https://github.com/hashicorp/nomad/blob/master/api/compose_test.go)

[Raffo]

@dadgar Can you explain what needs to be done here? It's not really clear to me.

[dadgar]

You will notice that the two packages duplicate all structs returned by the HTTP API. I linked an example. So the task is really to make the API layer return structs defined in nomad/structs

nomad/structs package
api package

[Raffo]

@dadgar Could this be what you want? Raffo@65aaad3
If so, I could update my fork with the newer commits from master and submit a PR.

[dadgar]

@Raffo: Yes that is exactly what I wanted! I left a few comments on your commit. The command (cli) package would probably have to be updated too!

[Raffo]

@dadgar I'll have a look at your comments tomorrow and I'll try to address them. After that, should I update my fork from upstream? I guess there are many new commits and I have no idea if the merge will be painful... tell me what you prefer.

[dadgar]

@Raffo: Yeah exactly, I would rebase your branch and then create a PR.

[dadgar]

@Raffo: we actually decided to keep the duplicates as a compatibility layer in case the two ever diverge. I really appreciate the effort!

[Raffo]

Well, it was fun anyways :-)

[github-actions]

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.