Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace structs.CSIPlugin -> api.CSIPlugin conversion #10470

Closed
tgross opened this issue Apr 29, 2021 · 2 comments · Fixed by #12583
Closed

replace structs.CSIPlugin -> api.CSIPlugin conversion #10470

tgross opened this issue Apr 29, 2021 · 2 comments · Fixed by #12583
Assignees
@tgross
Labels
theme/api HTTP API and SDK issues theme/cleanup theme/storage

Comments

@tgross
Copy link
Member

tgross commented Apr 29, 2021

In #8590 we introduced a manual conversion between structs.CSIPlugin and api.CSIPlugin. This proved to be fiddly and error-prone. #10202 introduced some encoding improvements that make it possible to remove most of this code so that we can implement a few hooks for fields we want to redact and that's it.
@tgross tgross mentioned this issue Apr 29, 2021
Open
@tgross
Copy link
Member Author

tgross commented Jun 22, 2021

cc @DerekStrickland as a heads up

@DerekStrickland DerekStrickland removed their assignment Nov 9, 2021
tgross added a commit that referenced this issue Feb 24, 2022
@tgross
CSI: ensure all fields are mapped from structs to api response
c014116 
In PR #12108 we added missing fields to the plugin response, but we
didn't include the manual serialization steps that we need until
issue #10470 is resolved.
@tgross tgross mentioned this issue Feb 24, 2022
Merged
tgross added a commit that referenced this issue Feb 24, 2022
@tgross
CSI: ensure all fields are mapped from structs to api response (#12124)
21aa764 
In PR #12108 we added missing fields to the plugin response, but we
didn't include the manual serialization steps that we need until
issue #10470 is resolved.
@tgross tgross mentioned this issue Feb 28, 2022
Closed
@tgross tgross mentioned this issue Mar 3, 2022
Merged
tgross added a commit that referenced this issue Mar 3, 2022
@tgross
csi: add missing fields to HTTP API response
cfac3c9 
The HTTP endpoint for CSI manually serializes the internal struct to
the API struct for purposes of redaction (see also #10470). Add fields
that were missing from this serialization so they don't show up as
always empty in the API response.
tgross added a commit that referenced this issue Mar 3, 2022
@tgross
csi: add missing fields to HTTP API response (#12178)
cd928d2 
The HTTP endpoint for CSI manually serializes the internal struct to
the API struct for purposes of redaction (see also #10470). Add fields
that were missing from this serialization so they don't show up as
always empty in the API response.
@tgross tgross self-assigned this Apr 15, 2022
@tgross tgross mentioned this issue Apr 15, 2022
Merged
This was referenced Apr 19, 2022
Merged
Merged
Merged
Merged
@github-actions
Copy link

github-actions bot commented Oct 9, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tgross tgross

Labels
theme/api HTTP API and SDK issues theme/cleanup theme/storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CSI: replace structs->api with serialization extension hashicorp/nomad
2 participants
@DerekStrickland @tgross