Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'nomad volume status' mount_options redaction is confusing #9825

Closed
tgross opened this issue Jan 15, 2021 · 1 comment · Fixed by #12150
Closed

'nomad volume status' mount_options redaction is confusing #9825

tgross opened this issue Jan 15, 2021 · 1 comment · Fixed by #12150

Comments

@tgross
Copy link
Member

tgross commented Jan 15, 2021

The mount_options field for a CSI volume can contain sensitive data, so we redact it in all our logs and API response. But the nomad volume status command shows a Mount Options = <none> field because we null-out the field when we convert from nomad/structs to api/structs (ref csi_endpoint.go#L110-L113). We should instead either send the [REDACTED] message over the wire when the value is non-nil (preferred) or remove the field from the command output entirely.

Note for reviewers: this may get tossed if I manage to get to #10470 but that's not on my "immediate todo" list.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant