Consul dependency updates #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plus all the other dependencies that pulled in.
Consujl moved from logger -> logging and incorporated hclog but otherwise it is pretty much the same. Changes mostly involved swapping out our adaptations to their old version not using hclog.
Consul updated their prometheus telemetry setup to use go-metrics/prometheus's options struct. This reflects that change and the few tweaks needed related to that update.
StatusHandler is an internal public struct used to track service status. This replaces the older Notify interface, subsuming it as a field. The Notify interface itself (used on a field of the StatusHandler) also has added a new method, ServiceExists, which was added as part of the Consul's Alias feature and which we don't support so use add a stubbed out method. The IDs used to track the checks have also changed from a string to a struct. The struct contains the string and some enterprise meta data. For now we just ignore the enterprise portion internally.
eikenb
force-pushed
the
dependency-updates
branch
from
cea6635 to
824ec85
Compare
None of these caused any issues.
lornasong
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the hashicorp/consul dependencies plus those it needs and then fix the problems that came up.
Fixes #132
Fixes #84