Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update consul dependency #132

Closed
3 tasks done
eikenb opened this issue May 17, 2022 · 0 comments · Fixed by #134
Closed
3 tasks done

Update consul dependency #132

eikenb opened this issue May 17, 2022 · 0 comments · Fixed by #134
Assignees
Labels
Milestone

Comments

@eikenb
Copy link
Contributor

eikenb commented May 17, 2022

The dependencies on internal hashicorp/consul modules need to be updated to address bugs and possible security issues. While removing them or migrating them out would be very nice (#113) that is out of scope in the short term and we need these fixes...

So far I've identified several large changes. Decided to open a ticket to track my progress. That last one (StatusHandler) looks bad.

  • consul/logger moved to consul/logging with a few other small changes
  • PrometheusRetentionTime moved into PrometheusOpts (with more options - in consul/lib/telemetry.go)
  • consul/agent/checks/check.go changed from using an Notify interface on all the check structs to using a StatusHandler object defined in that same file.
@eikenb eikenb added the bug label May 17, 2022
@eikenb eikenb added this to the v0.6.1 milestone May 17, 2022
@eikenb eikenb self-assigned this May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant