fix: started adding a yachli example and taskfile #1132

jeromy-cannon · 2025-01-09T13:55:22Z

Description

This pull request changes the following:

added flags for task helper to handle various gke scenarios
fixed task helper log message about package.json
added task helper dev flag on solo calls to increase logging
fixed kubectl port-forward issue
added task helper solo freeze restart command
rebased Alex's changes in from chore: add jvm algorithm analysis flag for latitude example #1093 to work on his stuff
updated solo gke test example to deploy mirror node and json rpc relay and expose external load balancer ip addresses
changed certain log statements from debug to info
updated mirror node to update cluster setup chart twice if needed so that cert manager and its CRDs are installed in a separate call from the certificate issuers that leverage it
increased error handling and logging in account manager and k8 port forward to root cause an issue
bumped solo chart to 0.42.4

Related Issues

Signed-off-by: Alex Kuzmin <[email protected]>

github-actions · 2025-01-09T13:57:37Z

Unit Test Results - Linux

1 files ±0 58 suites ±0 3s ⏱️ ±0s
227 tests ±0 227 ✅ ±0 0 💤 ±0 0 ❌ ±0
232 runs ±0 232 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 0c7cec7. ± Comparison against base commit 5180a76.

♻️ This comment has been updated with latest results.

github-actions · 2025-01-09T13:59:06Z

Unit Test Results - Windows

1 files ±0 58 suites ±0 12s ⏱️ -3s
227 tests ±0 227 ✅ ±0 0 💤 ±0 0 ❌ ±0
232 runs ±0 232 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 0c7cec7. ± Comparison against base commit 5180a76.

♻️ This comment has been updated with latest results.

github-actions · 2025-01-09T14:41:54Z

E2E Test Report

16 files 121 suites 1h 24m 39s ⏱️
258 tests 258 ✅ 0 💤 0 ❌
261 runs 261 ✅ 0 💤 0 ❌

Results for commit 0c7cec7.

♻️ This comment has been updated with latest results.

codacy-production · 2025-01-09T14:42:10Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for `5180a76`¹	✅ 63.91%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`5180a76`)	Report Missing	Report Missing	Report Missing
Head commit (`0c7cec7`)	20809	17425	83.74%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#1132)	338	216	63.91%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

codecov · 2025-01-09T14:48:00Z

Codecov Report

Attention: Patch coverage is 63.90533% with 122 lines in your changes missing coverage. Please review.

Project coverage is 83.39%. Comparing base (ed6527b) to head (0c7cec7).
Report is 37 commits behind head on main.

Files with missing lines	Patch %	Lines
src/commands/mirror_node.ts	14.81%	46 Missing ⚠️
src/core/account_manager.ts	80.97%	43 Missing ⚠️
src/commands/account.ts	0.00%	12 Missing ⚠️
src/commands/network.ts	0.00%	9 Missing ⚠️
src/commands/relay.ts	0.00%	5 Missing ⚠️
src/core/k8.ts	80.95%	4 Missing ⚠️
src/core/yargs_command.ts	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1132      +/-   ##
==========================================
- Coverage   83.67%   83.39%   -0.28%     
==========================================
  Files          77       77              
  Lines       20634    20809     +175     
  Branches     1397     1426      +29     
==========================================
+ Hits        17265    17354      +89     
- Misses       3326     3412      +86     
  Partials       43       43

Files with missing lines	Coverage Δ
src/core/helm.ts	`98.11% <100.00%> (ø)`
src/core/logging.ts	`77.71% <100.00%> (+0.12%)`	⬆️
src/core/platform_installer.ts	`88.12% <100.00%> (+0.03%)`	⬆️
src/core/shell_runner.ts	`100.00% <100.00%> (+3.22%)`	⬆️
version.ts	`100.00% <100.00%> (ø)`
src/core/yargs_command.ts	`30.00% <0.00%> (ø)`
src/core/k8.ts	`85.44% <80.95%> (-0.34%)`	⬇️
src/commands/relay.ts	`82.02% <0.00%> (-0.18%)`	⬇️
src/commands/network.ts	`66.12% <0.00%> (-1.07%)`	⬇️
src/commands/account.ts	`75.86% <0.00%> (ø)`
... and 2 more

... and 14 files with indirect coverage changes

Signed-off-by: Alex Kuzmin <[email protected]>

examples/address-book/Taskfile.yml

examples/solo-gke-test/Taskfile.yml

src/commands/mirror_node.ts

version.ts

Signed-off-by: Jeromy Cannon <[email protected]>

…node Signed-off-by: Jeromy Cannon <[email protected]>

Signed-off-by: Jeromy Cannon <[email protected]>

## [0.33.0](v0.32.0...v0.33.0) (2025-01-13) ### Features * add support for genesis throttle configuration ([#1026](#1026)) ([d8903a8](d8903a8)) * enable Blockstreams and uploader ([#1109](#1109)) ([ed6527b](ed6527b)) * inspect existing cluster resources during cluster setup ([#1094](#1094)) ([808516c](808516c)) * production readiness pass custom mirror node postgresql credentials and server address ([#1128](#1128)) ([f8b7e41](f8b7e41)) * support using GCS for backup uploader ([#1130](#1130)) ([5fe2f4e](5fe2f4e)) * update genesis-network.json to add roster entries and more ([#1122](#1122)) ([c27d1d6](c27d1d6)) * Updating solo to leverage changes after moving acme-cluster-issuer and haproxy-ingress out of mirror-node-explorer ([#1079](#1079)) ([7965894](7965894)) * use gcs for stream file storage ([#994](#994)) ([04d5806](04d5806)) ### Bug Fixes * add missing images, fix debug page images ([#1092](#1092)) ([4073d31](4073d31)) * Bug when running `solo cluster connect` after fresh install ([#1123](#1123)) ([1cd0e28](1cd0e28)) * bump solo-charts to 0.42.2 to pull in blockStreams fix ([#1138](#1138)) ([c482895](c482895)) * bump versions of hedera, json rpc relay, and mirror node ([#1147](#1147)) ([0784b46](0784b46)) * clarify how to use nvm ([#1125](#1125)) ([bdc1873](bdc1873)) * commit message of auto update ([#1106](#1106)) ([a3231f9](a3231f9)) * external link rendering ([#1118](#1118)) ([28af1fe](28af1fe)) * file size empty error when throttle file is provided on command line ([#1140](#1140)) ([5180a76](5180a76)) * fixed release artifact version issue and updated readme link ([#1090](#1090)) ([84e6611](84e6611)) * **lease:** reworks the previous fix addressing renewal issues ([#1105](#1105)) ([5edb9c9](5edb9c9)) * should run `npm install` before build ([#1117](#1117)) ([3398875](3398875)) * solo deployment create should use email address in local config if it is already there instead of prompting the user for it ([#1112](#1112)) ([362df60](362df60)) * started adding a yachli example and taskfile ([#1132](#1132)) ([8753723](8753723)) * update to AccountManager._getNodeClient() to parallel node connection setup ([#1091](#1091)) ([4959a12](4959a12))

swirlds-automation · 2025-01-13T21:30:37Z

🎉 This PR is included in version 0.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

swirlds-automation · 2025-01-21T02:01:39Z

🎉 This PR is included in version 0.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

alex-kuzmin-hg added 16 commits December 31, 2024 12:06

charts 0.39

58bb4b6

Signed-off-by: Alex Kuzmin <[email protected]>

Minor fix

377287e

Signed-off-by: Alex Kuzmin <[email protected]>

Use Dev throttling by default

5726607

Signed-off-by: Alex Kuzmin <[email protected]>

Merge branch 'main' into solo-charts-0.38.2

147ab67

Proper name for throttling props

e34309f

Signed-off-by: Alex Kuzmin <[email protected]>

fix

479577a

Signed-off-by: Alex Kuzmin <[email protected]>

28 cpus for NLG min

6287a98

Signed-off-by: Alex Kuzmin <[email protected]>

20cpu

3602a1e

Signed-off-by: Alex Kuzmin <[email protected]>

Temp solo-chart 0.36.3

a93f7dd

Signed-off-by: Alex Kuzmin <[email protected]>

Workaround hanging

c567fea

Signed-off-by: Alex Kuzmin <[email protected]>

reverted to last known good config

3149252

Signed-off-by: Alex Kuzmin <[email protected]>

solo-charts=0.38.2

d5b45c7

Signed-off-by: Alex Kuzmin <[email protected]>

commented CONSENSUS_NODE_VERSION

62bfefc

Signed-off-by: Alex Kuzmin <[email protected]>

v0.39.0

89de93c

Signed-off-by: Alex Kuzmin <[email protected]>

Reduced CPU request to fit NLG per each namespace

3f3e82b

Signed-off-by: Alex Kuzmin <[email protected]>

Correct format for nodeselector for NLG

8ce7acb

Signed-off-by: Alex Kuzmin <[email protected]>

jeromy-cannon self-assigned this Jan 9, 2025

alex-kuzmin-hg added 2 commits January 9, 2025 17:10

Merge branch 'main' into solo-charts-0.38.2

3458e47

charts 0.42.1

f201cd4

Signed-off-by: Alex Kuzmin <[email protected]>

jeromy-cannon force-pushed the yahcli branch from 8c1cf0b to ac3143a Compare January 10, 2025 13:59

alex-kuzmin-hg added 5 commits January 10, 2025 06:54

Merge branch 'main' into solo-charts-0.38.2

0465e7d

solo-charts 0.42.2

76ddc7f

Signed-off-by: Alex Kuzmin <[email protected]>

Merge branch 'main' into solo-charts-0.38.2

3d17cb9

loadBalancerEnabled: true

8982afa

Signed-off-by: Alex Kuzmin <[email protected]>

loadbalancer mode

b9ab9ce

Signed-off-by: Alex Kuzmin <[email protected]>

jeromy-cannon commented Jan 13, 2025

View reviewed changes

examples/address-book/Taskfile.yml Outdated Show resolved Hide resolved

jeromy-cannon commented Jan 13, 2025

View reviewed changes

examples/solo-gke-test/Taskfile.yml Outdated Show resolved Hide resolved

jeromy-cannon commented Jan 13, 2025

View reviewed changes

src/commands/mirror_node.ts Show resolved Hide resolved

jeromy-cannon changed the title ~~started adding a yachli example and taskfile~~ fix: started adding a yachli example and taskfile Jan 13, 2025

jeromy-cannon commented Jan 13, 2025

View reviewed changes

version.ts Outdated Show resolved Hide resolved

jeromy-cannon added 8 commits January 13, 2025 13:58

fixed unit test failure

2066605

Signed-off-by: Jeromy Cannon <[email protected]>

fixed missing command bug

06e3fd9

Signed-off-by: Jeromy Cannon <[email protected]>

bump solo chart to 0.42.4

743bb0b

Signed-off-by: Jeromy Cannon <[email protected]>

added code comment on cert manager update of cluster setup in mirror …

2caf602

…node Signed-off-by: Jeromy Cannon <[email protected]>

removed gke ip addresses

5bf135c

Signed-off-by: Jeromy Cannon <[email protected]>

added descriptions to tasks

9956d51

Signed-off-by: Jeromy Cannon <[email protected]>

added address book readme

b609095

Signed-off-by: Jeromy Cannon <[email protected]>

set permissions on HEDERA_HGCAPP_DIR

0c7cec7

Signed-off-by: Jeromy Cannon <[email protected]>

jeromy-cannon marked this pull request as ready for review January 13, 2025 15:57

jeromy-cannon requested review from a team and leninmehedy as code owners January 13, 2025 15:57

jeromy-cannon requested review from Ivo-Yankov, nathanklick, JeffreyDallas and instamenta January 13, 2025 16:07

nathanklick approved these changes Jan 13, 2025

View reviewed changes

jeromy-cannon merged commit 8753723 into main Jan 13, 2025
38 of 41 checks passed

jeromy-cannon deleted the yahcli branch January 13, 2025 16:27

jeromy-cannon mentioned this pull request Jan 13, 2025

fix: use "double fork" to invoke port forward within Taskfile #1148

Merged

swirlds-automation added the released label Jan 13, 2025

swirlds-automation added the released on @0.33.x label Jan 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: started adding a yachli example and taskfile #1132

fix: started adding a yachli example and taskfile #1132

jeromy-cannon commented Jan 9, 2025 •

edited

Loading

github-actions bot commented Jan 9, 2025 •

edited

Loading

github-actions bot commented Jan 9, 2025 •

edited

Loading

github-actions bot commented Jan 9, 2025 •

edited

Loading

codacy-production bot commented Jan 9, 2025 •

edited

Loading

codecov bot commented Jan 9, 2025 •

edited

Loading

swirlds-automation commented Jan 13, 2025

swirlds-automation commented Jan 21, 2025

fix: started adding a yachli example and taskfile #1132

fix: started adding a yachli example and taskfile #1132

Conversation

jeromy-cannon commented Jan 9, 2025 • edited Loading

Description

Related Issues

github-actions bot commented Jan 9, 2025 • edited Loading

Unit Test Results - Linux

github-actions bot commented Jan 9, 2025 • edited Loading

Unit Test Results - Windows

github-actions bot commented Jan 9, 2025 • edited Loading

E2E Test Report

codacy-production bot commented Jan 9, 2025 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

Footnotes

codecov bot commented Jan 9, 2025 • edited Loading

Codecov Report

swirlds-automation commented Jan 13, 2025

swirlds-automation commented Jan 21, 2025

jeromy-cannon commented Jan 9, 2025 •

edited

Loading

github-actions bot commented Jan 9, 2025 •

edited

Loading

github-actions bot commented Jan 9, 2025 •

edited

Loading

github-actions bot commented Jan 9, 2025 •

edited

Loading

codacy-production bot commented Jan 9, 2025 •

edited

Loading

codecov bot commented Jan 9, 2025 •

edited

Loading