Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: production readiness pass custom mirror node postgresql credentials and server address #1128

Conversation

instamenta
Copy link
Contributor

@instamenta instamenta commented Jan 8, 2025

Description

  • adds new flag custom-mirror-node-database-values-path to specify values file for external database configuration
  • writes SQL query inside .solo/cache/database-seeding-query.sql for seeding the external database
  • adds values.yaml and init.sh inside /examples/custom-mirror-node-database

Related Issues

…iness-pass-custom-mirror-node-postgresql-credentials-and-server-address-along-with-disabling-stackgres-deployment

# Conflicts:
#	src/commands/mirror_node.ts
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Unit Test Results - Linux

  1 files  ±0   58 suites  ±0   3s ⏱️ ±0s
227 tests ±0  227 ✅ ±0  0 💤 ±0  0 ❌ ±0 
232 runs  ±0  232 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1e2ea5c. ± Comparison against base commit 5fe2f4e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Unit Test Results - Windows

  1 files  ±0   58 suites  ±0   12s ⏱️ -3s
227 tests ±0  227 ✅ ±0  0 💤 ±0  0 ❌ ±0 
232 runs  ±0  232 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1e2ea5c. ± Comparison against base commit 5fe2f4e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

E2E Test Report

 16 files  ±0  121 suites  ±0   1h 22m 44s ⏱️ + 1m 1s
258 tests ±0  258 ✅ ±0  0 💤 ±0  0 ❌ ±0 
261 runs  ±0  261 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1e2ea5c. ± Comparison against base commit 5fe2f4e.

♻️ This comment has been updated with latest results.

Copy link

codacy-production bot commented Jan 9, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.05% (target: -1.00%) 60.53%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5fe2f4e) 20661 17432 84.37%
Head commit (1e2ea5c) 20724 (+63) 17474 (+42) 84.32% (-0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1128) 38 23 60.53%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 55.26316% with 17 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@5fe2f4e). Learn more about missing BASE report.
Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
src/commands/mirror_node.ts 34.61% 15 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1128   +/-   ##
=======================================
  Coverage        ?   83.53%           
=======================================
  Files           ?       77           
  Lines           ?    20724           
  Branches        ?     1361           
=======================================
  Hits            ?    17312           
  Misses          ?     3357           
  Partials        ?       55           
Files with missing lines Coverage Δ
src/commands/flags.ts 75.27% <100.00%> (ø)
src/commands/mirror_node.ts 73.09% <34.61%> (ø)

Impacted file tree graph

…iness-pass-custom-mirror-node-postgresql-credentials-and-server-address-along-with-disabling-stackgres-deployment
…iness-pass-custom-mirror-node-postgresql-credentials-and-server-address-along-with-disabling-stackgres-deployment
…working on fixing database seeding

Signed-off-by: instamenta <[email protected]>
…ase, polished the values file and improved added changes to mirror-node command

Signed-off-by: instamenta <[email protected]>
Signed-off-by: instamenta <[email protected]>
@instamenta instamenta marked this pull request as ready for review January 10, 2025 13:34
jeromy-cannon
jeromy-cannon previously approved these changes Jan 10, 2025
@jeromy-cannon jeromy-cannon merged commit f8b7e41 into main Jan 10, 2025
41 of 42 checks passed
@jeromy-cannon jeromy-cannon deleted the 00934-production-readiness-pass-custom-mirror-node-postgresql-credentials-and-server-address-along-with-disabling-stackgres-deployment branch January 10, 2025 14:57
swirlds-automation added a commit that referenced this pull request Jan 13, 2025
## [0.33.0](v0.32.0...v0.33.0) (2025-01-13)

### Features

* add support for genesis throttle configuration ([#1026](#1026)) ([d8903a8](d8903a8))
* enable Blockstreams and uploader ([#1109](#1109)) ([ed6527b](ed6527b))
* inspect existing cluster resources during cluster setup ([#1094](#1094)) ([808516c](808516c))
* production readiness pass custom mirror node postgresql credentials and server address ([#1128](#1128)) ([f8b7e41](f8b7e41))
* support using GCS for backup uploader ([#1130](#1130)) ([5fe2f4e](5fe2f4e))
* update genesis-network.json to add roster entries and more ([#1122](#1122)) ([c27d1d6](c27d1d6))
* Updating solo to leverage changes after moving acme-cluster-issuer and haproxy-ingress out of mirror-node-explorer ([#1079](#1079)) ([7965894](7965894))
* use gcs for stream file storage ([#994](#994)) ([04d5806](04d5806))

### Bug Fixes

* add missing images, fix debug page images ([#1092](#1092)) ([4073d31](4073d31))
* Bug when running `solo cluster connect` after fresh install ([#1123](#1123)) ([1cd0e28](1cd0e28))
* bump solo-charts to 0.42.2 to pull in blockStreams fix ([#1138](#1138)) ([c482895](c482895))
* bump versions of hedera, json rpc relay, and mirror node ([#1147](#1147)) ([0784b46](0784b46))
* clarify how to use nvm ([#1125](#1125)) ([bdc1873](bdc1873))
* commit message of auto update ([#1106](#1106)) ([a3231f9](a3231f9))
* external link rendering ([#1118](#1118)) ([28af1fe](28af1fe))
* file size empty error when throttle file is provided on command line ([#1140](#1140)) ([5180a76](5180a76))
* fixed release artifact version issue and updated readme link ([#1090](#1090)) ([84e6611](84e6611))
* **lease:** reworks the previous fix addressing renewal issues ([#1105](#1105)) ([5edb9c9](5edb9c9))
* should run `npm install` before build ([#1117](#1117)) ([3398875](3398875))
* solo deployment create should use email address in local config if it is already there instead of prompting the user for it ([#1112](#1112)) ([362df60](362df60))
* started adding a yachli example and taskfile ([#1132](#1132)) ([8753723](8753723))
* update to AccountManager._getNodeClient() to parallel node connection setup ([#1091](#1091)) ([4959a12](4959a12))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants