Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix CryptographyTests #15529

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

OlegMazurov
Copy link
Contributor

Description:
Recent refactoring introduced SignatureComponents but swapped signatureBytes and publicKey during initialization.

Related issue(s):

Fixes #15528
Caused by #9902

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Oleg Mazurov <[email protected]>
@OlegMazurov OlegMazurov added the Base Crypto Tickets pertaining to the base crypto library label Sep 17, 2024
@OlegMazurov OlegMazurov added this to the v0.55 milestone Sep 17, 2024
@OlegMazurov OlegMazurov self-assigned this Sep 17, 2024
@OlegMazurov OlegMazurov requested review from a team as code owners September 17, 2024 15:57
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8786334) 109271 67495 61.77%
Head commit (d576f4e) 109271 (+0) 67495 (+0) 61.77% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#15529) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.23%. Comparing base (8786334) to head (d576f4e).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #15529   +/-   ##
==========================================
  Coverage      58.23%   58.23%           
  Complexity     21618    21618           
==========================================
  Files           2784     2784           
  Lines         109454   109454           
  Branches       11192    11192           
==========================================
  Hits           63737    63737           
  Misses         41849    41849           
  Partials        3868     3868           

Impacted file tree graph

@OlegMazurov OlegMazurov merged commit 855861f into develop Sep 17, 2024
72 of 73 checks passed
@OlegMazurov OlegMazurov deleted the 15528-D-fix-cryptographytests branch September 17, 2024 17:38
netopyr added a commit that referenced this pull request Sep 19, 2024
* develop: (22 commits)
  test: New HAPI test for TokenAirdrop transaction (#15348)
  test: unit test verifySyncInvalidEd25519() is not stable (#15534)
  chore: add `TracerBinding` interface for `TransactionExecutors`. (#15480)
  chore: Add missing javadocs in Consensus Service (#15299)
  fix: Validate `CustomFees` input arrays in `UpdateTokenCustomFeesDecoder` (#15520)
  feat: migrate event serialization to protobuf (#15417)
  fix: 15494: Improve VirtualLeafRecord serialization to bytes during flushes (#15512)
  docs: tss block signing proposal (#15160)
  fix: 15438: Eliminate busy loop in HalfDiskHashMap.endWriting() (#15439)
  build: cleanup settings.gradle.kts / remove build.gradle.kts (#15470)
  test: fix CryptographyTests (#15529)
  fix: recreate block hash from state (#15444)
  docs: Proposal Process Update - Specify post-acceptance non-material update procedure (#15447)
  chore: testnet event hashing (#15432)
  fix: 15167: Remove timeout from reconnect/rehash Iterators (#15468)
  chore: remove snapshot ops (#15462)
  feat: Add TokenUpdateNFTs as a smart contract operation v2 (#15445)
  feat: introduce PbjRecordHasher and RosterUtils.hash(Roster) (#15457)
  fix: Precision loss for gas calculation of HTS system contracts v2 (#15446)
  chore: correct the variable name in roster.proto (#15465)
  ...

# Conflicts:
#	hedera-node/hedera-smart-contract-service-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/scope/HandleHederaOperations.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Base Crypto Tickets pertaining to the base crypto library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix CryptographyTests
4 participants