Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add TracerBinding interface for TransactionExecutors. #15480

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

tinker-michaelj
Copy link
Collaborator

Signed-off-by: Michael Tinker <[email protected]>
@tinker-michaelj tinker-michaelj requested review from a team and rbair23 September 16, 2024 16:19
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (aa3ca6b) 109106 67425 61.80%
Head commit (0142417) 109112 (+6) 67431 (+6) 61.80% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#15480) 12 12 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.25%. Comparing base (aa3ca6b) to head (0142417).
Report is 13 commits behind head on develop.

Files with missing lines Patch % Lines
...app/workflows/standalone/TransactionExecutors.java 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #15480   +/-   ##
==========================================
  Coverage      58.25%   58.25%           
- Complexity     21613    21614    +1     
==========================================
  Files           2781     2781           
  Lines         109289   109295    +6     
  Branches       11181    11181           
==========================================
+ Hits           63668    63673    +5     
  Misses         41754    41754           
- Partials        3867     3868    +1     
Files with missing lines Coverage Δ
...app/workflows/standalone/TransactionExecutors.java 97.22% <91.66%> (-2.78%) ⬇️

Impacted file tree graph

@tinker-michaelj tinker-michaelj added this to the v0.55 milestone Sep 16, 2024
@tinker-michaelj tinker-michaelj self-assigned this Sep 16, 2024
Copy link
Collaborator

@IvanKavaldzhiev IvanKavaldzhiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @tinker-michaelj

@tinker-michaelj tinker-michaelj merged commit 03f9059 into develop Sep 18, 2024
47 of 55 checks passed
@tinker-michaelj tinker-michaelj deleted the 15479-tracer-binding branch September 18, 2024 15:04
netopyr added a commit that referenced this pull request Sep 19, 2024
* develop: (22 commits)
  test: New HAPI test for TokenAirdrop transaction (#15348)
  test: unit test verifySyncInvalidEd25519() is not stable (#15534)
  chore: add `TracerBinding` interface for `TransactionExecutors`. (#15480)
  chore: Add missing javadocs in Consensus Service (#15299)
  fix: Validate `CustomFees` input arrays in `UpdateTokenCustomFeesDecoder` (#15520)
  feat: migrate event serialization to protobuf (#15417)
  fix: 15494: Improve VirtualLeafRecord serialization to bytes during flushes (#15512)
  docs: tss block signing proposal (#15160)
  fix: 15438: Eliminate busy loop in HalfDiskHashMap.endWriting() (#15439)
  build: cleanup settings.gradle.kts / remove build.gradle.kts (#15470)
  test: fix CryptographyTests (#15529)
  fix: recreate block hash from state (#15444)
  docs: Proposal Process Update - Specify post-acceptance non-material update procedure (#15447)
  chore: testnet event hashing (#15432)
  fix: 15167: Remove timeout from reconnect/rehash Iterators (#15468)
  chore: remove snapshot ops (#15462)
  feat: Add TokenUpdateNFTs as a smart contract operation v2 (#15445)
  feat: introduce PbjRecordHasher and RosterUtils.hash(Roster) (#15457)
  fix: Precision loss for gas calculation of HTS system contracts v2 (#15446)
  chore: correct the variable name in roster.proto (#15465)
  ...

# Conflicts:
#	hedera-node/hedera-smart-contract-service-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/scope/HandleHederaOperations.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a TracerBinding strategy to TransactionExecutors
3 participants