Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: example for HIP-869 #2443

Conversation

svetoslav-nikol0v
Copy link
Contributor

Description:

Example that demonstrates the right way how to build a NodeCreateTransaction, NodeUpdateTransaction and NodeDeleteTransaction transactions and behaviour of the whole functionality.

Fixes #2407

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@svetoslav-nikol0v svetoslav-nikol0v requested review from a team as code owners August 5, 2024 11:42
@svetoslav-nikol0v svetoslav-nikol0v requested review from rwalworth and agadzhalov and removed request for rwalworth August 5, 2024 11:42
Copy link

sonarqubecloud bot commented Aug 5, 2024

@svetoslav-nikol0v svetoslav-nikol0v merged commit 056f10f into hip-869-dynamic-address-book Aug 6, 2024
2 checks passed
@svetoslav-nikol0v svetoslav-nikol0v deleted the 2407-add-an-example-for-hip-869 branch August 6, 2024 16:13
svetoslav-nikol0v added a commit that referenced this pull request Aug 6, 2024
* chore: formatting

Signed-off-by: Svet <[email protected]>

* add: example

Signed-off-by: Svet <[email protected]>

* chore: formatting

Signed-off-by: Svet <[email protected]>

* update: example

Signed-off-by: Svet <[email protected]>

---------

Signed-off-by: Svet <[email protected]>
ivaylonikolov7 pushed a commit that referenced this pull request Aug 13, 2024
* feat: create node transaction (#2402)

* feat: add addressBook channel

Signed-off-by: svetoslav-nikol0v <[email protected]>

* feat: implement NodeCreateTransaction class

Signed-off-by: svetoslav-nikol0v <[email protected]>

* feat: implement ServiceEndpoint class

Signed-off-by: svetoslav-nikol0v <[email protected]>

* chore: export new classess

Signed-off-by: svetoslav-nikol0v <[email protected]>

* update: proto changes

Signed-off-by: svetoslav-nikol0v <[email protected]>

* update: transaction receipt

Signed-off-by: svetoslav-nikol0v <[email protected]>

* fix: unit tests

Signed-off-by: svetoslav-nikol0v <[email protected]>

* fix: method in node create transaction

Signed-off-by: svetoslav-nikol0v <[email protected]>

---------

Signed-off-by: svetoslav-nikol0v <[email protected]>

* fix: integration test

Signed-off-by: svetoslav-nikol0v <[email protected]>

* chore: remove .only

Signed-off-by: svetoslav-nikol0v <[email protected]>

* feat: node delete transaction (#2404)

Signed-off-by: svetoslav-nikol0v <[email protected]>

* feat: node update transaction (#2405)

* feat: node update transaction

Signed-off-by: svetoslav-nikol0v <[email protected]>

* fix: adjustments

Signed-off-by: svetoslav-nikol0v <[email protected]>

---------

Signed-off-by: svetoslav-nikol0v <[email protected]>

* update: example for HIP-869 (#2443)

* chore: formatting

Signed-off-by: Svet <[email protected]>

* add: example

Signed-off-by: Svet <[email protected]>

* chore: formatting

Signed-off-by: Svet <[email protected]>

* update: example

Signed-off-by: Svet <[email protected]>

---------

Signed-off-by: Svet <[email protected]>

* update: remove default values

Signed-off-by: Svet <[email protected]>

---------

Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: Svet <[email protected]>
ivaylogarnev-limechain pushed a commit that referenced this pull request Aug 22, 2024
* feat: create node transaction (#2402)

* feat: add addressBook channel

Signed-off-by: svetoslav-nikol0v <[email protected]>

* feat: implement NodeCreateTransaction class

Signed-off-by: svetoslav-nikol0v <[email protected]>

* feat: implement ServiceEndpoint class

Signed-off-by: svetoslav-nikol0v <[email protected]>

* chore: export new classess

Signed-off-by: svetoslav-nikol0v <[email protected]>

* update: proto changes

Signed-off-by: svetoslav-nikol0v <[email protected]>

* update: transaction receipt

Signed-off-by: svetoslav-nikol0v <[email protected]>

* fix: unit tests

Signed-off-by: svetoslav-nikol0v <[email protected]>

* fix: method in node create transaction

Signed-off-by: svetoslav-nikol0v <[email protected]>

---------

Signed-off-by: svetoslav-nikol0v <[email protected]>

* fix: integration test

Signed-off-by: svetoslav-nikol0v <[email protected]>

* chore: remove .only

Signed-off-by: svetoslav-nikol0v <[email protected]>

* feat: node delete transaction (#2404)

Signed-off-by: svetoslav-nikol0v <[email protected]>

* feat: node update transaction (#2405)

* feat: node update transaction

Signed-off-by: svetoslav-nikol0v <[email protected]>

* fix: adjustments

Signed-off-by: svetoslav-nikol0v <[email protected]>

---------

Signed-off-by: svetoslav-nikol0v <[email protected]>

* update: example for HIP-869 (#2443)

* chore: formatting

Signed-off-by: Svet <[email protected]>

* add: example

Signed-off-by: Svet <[email protected]>

* chore: formatting

Signed-off-by: Svet <[email protected]>

* update: example

Signed-off-by: Svet <[email protected]>

---------

Signed-off-by: Svet <[email protected]>

* update: remove default values

Signed-off-by: Svet <[email protected]>

---------

Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: Svet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant