-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: node delete transaction #2404
Merged
svetoslav-nikol0v
merged 1 commit into
hip-869-dynamic-address-book
from
2337-add-hip-869-nodedeletetransaction
Jul 19, 2024
Merged
feat: node delete transaction #2404
svetoslav-nikol0v
merged 1 commit into
hip-869-dynamic-address-book
from
2337-add-hip-869-nodedeletetransaction
Jul 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svetoslav-nikol0v
requested review from
rwalworth and
agadzhalov
and removed request for
rwalworth
July 18, 2024 13:18
Signed-off-by: svetoslav-nikol0v <[email protected]>
svetoslav-nikol0v
changed the base branch from
main
to
hip-869-dynamic-address-book
July 18, 2024 13:22
Quality Gate passedIssues Measures |
agadzhalov
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
svetoslav-nikol0v
merged commit Jul 19, 2024
a194b3a
into
hip-869-dynamic-address-book
6 of 7 checks passed
svetoslav-nikol0v
added a commit
that referenced
this pull request
Aug 6, 2024
Signed-off-by: svetoslav-nikol0v <[email protected]>
ivaylonikolov7
pushed a commit
that referenced
this pull request
Aug 13, 2024
* feat: create node transaction (#2402) * feat: add addressBook channel Signed-off-by: svetoslav-nikol0v <[email protected]> * feat: implement NodeCreateTransaction class Signed-off-by: svetoslav-nikol0v <[email protected]> * feat: implement ServiceEndpoint class Signed-off-by: svetoslav-nikol0v <[email protected]> * chore: export new classess Signed-off-by: svetoslav-nikol0v <[email protected]> * update: proto changes Signed-off-by: svetoslav-nikol0v <[email protected]> * update: transaction receipt Signed-off-by: svetoslav-nikol0v <[email protected]> * fix: unit tests Signed-off-by: svetoslav-nikol0v <[email protected]> * fix: method in node create transaction Signed-off-by: svetoslav-nikol0v <[email protected]> --------- Signed-off-by: svetoslav-nikol0v <[email protected]> * fix: integration test Signed-off-by: svetoslav-nikol0v <[email protected]> * chore: remove .only Signed-off-by: svetoslav-nikol0v <[email protected]> * feat: node delete transaction (#2404) Signed-off-by: svetoslav-nikol0v <[email protected]> * feat: node update transaction (#2405) * feat: node update transaction Signed-off-by: svetoslav-nikol0v <[email protected]> * fix: adjustments Signed-off-by: svetoslav-nikol0v <[email protected]> --------- Signed-off-by: svetoslav-nikol0v <[email protected]> * update: example for HIP-869 (#2443) * chore: formatting Signed-off-by: Svet <[email protected]> * add: example Signed-off-by: Svet <[email protected]> * chore: formatting Signed-off-by: Svet <[email protected]> * update: example Signed-off-by: Svet <[email protected]> --------- Signed-off-by: Svet <[email protected]> * update: remove default values Signed-off-by: Svet <[email protected]> --------- Signed-off-by: svetoslav-nikol0v <[email protected]> Signed-off-by: Svet <[email protected]>
ivaylogarnev-limechain
pushed a commit
that referenced
this pull request
Aug 22, 2024
* feat: create node transaction (#2402) * feat: add addressBook channel Signed-off-by: svetoslav-nikol0v <[email protected]> * feat: implement NodeCreateTransaction class Signed-off-by: svetoslav-nikol0v <[email protected]> * feat: implement ServiceEndpoint class Signed-off-by: svetoslav-nikol0v <[email protected]> * chore: export new classess Signed-off-by: svetoslav-nikol0v <[email protected]> * update: proto changes Signed-off-by: svetoslav-nikol0v <[email protected]> * update: transaction receipt Signed-off-by: svetoslav-nikol0v <[email protected]> * fix: unit tests Signed-off-by: svetoslav-nikol0v <[email protected]> * fix: method in node create transaction Signed-off-by: svetoslav-nikol0v <[email protected]> --------- Signed-off-by: svetoslav-nikol0v <[email protected]> * fix: integration test Signed-off-by: svetoslav-nikol0v <[email protected]> * chore: remove .only Signed-off-by: svetoslav-nikol0v <[email protected]> * feat: node delete transaction (#2404) Signed-off-by: svetoslav-nikol0v <[email protected]> * feat: node update transaction (#2405) * feat: node update transaction Signed-off-by: svetoslav-nikol0v <[email protected]> * fix: adjustments Signed-off-by: svetoslav-nikol0v <[email protected]> --------- Signed-off-by: svetoslav-nikol0v <[email protected]> * update: example for HIP-869 (#2443) * chore: formatting Signed-off-by: Svet <[email protected]> * add: example Signed-off-by: Svet <[email protected]> * chore: formatting Signed-off-by: Svet <[email protected]> * update: example Signed-off-by: Svet <[email protected]> --------- Signed-off-by: Svet <[email protected]> * update: remove default values Signed-off-by: Svet <[email protected]> --------- Signed-off-by: svetoslav-nikol0v <[email protected]> Signed-off-by: Svet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is transaction allows to delete a node from the network. Part of HIP-869.
Fixes #2337
Checklist