Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: node delete transaction #2404

Conversation

svetoslav-nikol0v
Copy link
Contributor

@svetoslav-nikol0v svetoslav-nikol0v commented Jul 18, 2024

Description:

This is transaction allows to delete a node from the network. Part of HIP-869.

Fixes #2337

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@svetoslav-nikol0v svetoslav-nikol0v requested review from a team as code owners July 18, 2024 13:18
@svetoslav-nikol0v svetoslav-nikol0v requested review from rwalworth and agadzhalov and removed request for rwalworth July 18, 2024 13:18
Signed-off-by: svetoslav-nikol0v <[email protected]>
@svetoslav-nikol0v svetoslav-nikol0v changed the base branch from main to hip-869-dynamic-address-book July 18, 2024 13:22
Copy link

Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svetoslav-nikol0v svetoslav-nikol0v merged commit a194b3a into hip-869-dynamic-address-book Jul 19, 2024
6 of 7 checks passed
@svetoslav-nikol0v svetoslav-nikol0v deleted the 2337-add-hip-869-nodedeletetransaction branch July 19, 2024 11:35
svetoslav-nikol0v added a commit that referenced this pull request Aug 6, 2024
Signed-off-by: svetoslav-nikol0v <[email protected]>
ivaylonikolov7 pushed a commit that referenced this pull request Aug 13, 2024
* feat: create node transaction (#2402)

* feat: add addressBook channel

Signed-off-by: svetoslav-nikol0v <[email protected]>

* feat: implement NodeCreateTransaction class

Signed-off-by: svetoslav-nikol0v <[email protected]>

* feat: implement ServiceEndpoint class

Signed-off-by: svetoslav-nikol0v <[email protected]>

* chore: export new classess

Signed-off-by: svetoslav-nikol0v <[email protected]>

* update: proto changes

Signed-off-by: svetoslav-nikol0v <[email protected]>

* update: transaction receipt

Signed-off-by: svetoslav-nikol0v <[email protected]>

* fix: unit tests

Signed-off-by: svetoslav-nikol0v <[email protected]>

* fix: method in node create transaction

Signed-off-by: svetoslav-nikol0v <[email protected]>

---------

Signed-off-by: svetoslav-nikol0v <[email protected]>

* fix: integration test

Signed-off-by: svetoslav-nikol0v <[email protected]>

* chore: remove .only

Signed-off-by: svetoslav-nikol0v <[email protected]>

* feat: node delete transaction (#2404)

Signed-off-by: svetoslav-nikol0v <[email protected]>

* feat: node update transaction (#2405)

* feat: node update transaction

Signed-off-by: svetoslav-nikol0v <[email protected]>

* fix: adjustments

Signed-off-by: svetoslav-nikol0v <[email protected]>

---------

Signed-off-by: svetoslav-nikol0v <[email protected]>

* update: example for HIP-869 (#2443)

* chore: formatting

Signed-off-by: Svet <[email protected]>

* add: example

Signed-off-by: Svet <[email protected]>

* chore: formatting

Signed-off-by: Svet <[email protected]>

* update: example

Signed-off-by: Svet <[email protected]>

---------

Signed-off-by: Svet <[email protected]>

* update: remove default values

Signed-off-by: Svet <[email protected]>

---------

Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: Svet <[email protected]>
ivaylogarnev-limechain pushed a commit that referenced this pull request Aug 22, 2024
* feat: create node transaction (#2402)

* feat: add addressBook channel

Signed-off-by: svetoslav-nikol0v <[email protected]>

* feat: implement NodeCreateTransaction class

Signed-off-by: svetoslav-nikol0v <[email protected]>

* feat: implement ServiceEndpoint class

Signed-off-by: svetoslav-nikol0v <[email protected]>

* chore: export new classess

Signed-off-by: svetoslav-nikol0v <[email protected]>

* update: proto changes

Signed-off-by: svetoslav-nikol0v <[email protected]>

* update: transaction receipt

Signed-off-by: svetoslav-nikol0v <[email protected]>

* fix: unit tests

Signed-off-by: svetoslav-nikol0v <[email protected]>

* fix: method in node create transaction

Signed-off-by: svetoslav-nikol0v <[email protected]>

---------

Signed-off-by: svetoslav-nikol0v <[email protected]>

* fix: integration test

Signed-off-by: svetoslav-nikol0v <[email protected]>

* chore: remove .only

Signed-off-by: svetoslav-nikol0v <[email protected]>

* feat: node delete transaction (#2404)

Signed-off-by: svetoslav-nikol0v <[email protected]>

* feat: node update transaction (#2405)

* feat: node update transaction

Signed-off-by: svetoslav-nikol0v <[email protected]>

* fix: adjustments

Signed-off-by: svetoslav-nikol0v <[email protected]>

---------

Signed-off-by: svetoslav-nikol0v <[email protected]>

* update: example for HIP-869 (#2443)

* chore: formatting

Signed-off-by: Svet <[email protected]>

* add: example

Signed-off-by: Svet <[email protected]>

* chore: formatting

Signed-off-by: Svet <[email protected]>

* update: example

Signed-off-by: Svet <[email protected]>

---------

Signed-off-by: Svet <[email protected]>

* update: remove default values

Signed-off-by: Svet <[email protected]>

---------

Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: Svet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HIP-869: NodeDeleteTransaction
2 participants