Unhealthy node info #1605
Merged
Unhealthy node info #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
ochikov
requested changes
May 10, 2023
| @@ -651,6 +651,9 @@ export default class Executable { | |||
| ) { | |||
| // Increase the backoff for the particular node and remove it from | |||
| // the healthy node list | |||
| Logger.debug( | |||
| `Node with accountId: ${node.accountId.toString()} and proxy IP: ${node.address.toString()} is unhealthy` | |||
| ); | |||
There was a problem hiding this comment.
This error will be visible when the user enabled the logger. I will check with @Nana-EC if this is the requirement by the issue opened.
Signed-off-by: Petar Tonev <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
ochikov
approved these changes
May 11, 2023
monokaijs
pushed a commit
to monostarter/u2u-sdk-js
that referenced
this pull request
Jul 5, 2023
* add logger debug info about unhealthy nodes Signed-off-by: Petar Tonev <[email protected]> * after build Signed-off-by: Petar Tonev <[email protected]> * refactor a bit the message and test the logger functionality Signed-off-by: Petar Tonev <[email protected]> --------- Signed-off-by: Petar Tonev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added logging statement to show which node has been removed from the healthy nodes
Related issue(s):
Fixes #1603
Notes for reviewer:
Checklist