-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add about pages #263
Merged
Merged
Add about pages #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* replaced app with funnelapp and created new app instance * added route for new app to all views * replaced runtime use of app iwth current_app * renamed runfunnelserver.py to runfunnel.py * separated rqinit file for both applications * added app specific configuration * added comment for app specific config * fixed app order, removed unnecessary views from funnelapp and more fixes * renamed jsonify function name * moved model import inside function to avoid circular import * misc fixes * moving lastuser confix to app specific config files * added LASTUSER_COOKIE_DOMAIN to app specific config * fixed mui css issue with funnelapp * funnelindex page update with new UI * downloading CSV file instead of showing on tab * using content type text/csv * fixed placement of few hr tags * Call embedIframe only when preview video link is present. * misc fixes * reverted to index_jsonify function * removed unused function * using parent_spaces_test relationship to test * removed parent_spaces_test * Sync funnelindex with index. Change heading to bold on proposal page. * removed doubt
jace
requested changes
Sep 23, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing import, but otherwise good to merge.
jace
added a commit
that referenced
this pull request
Apr 6, 2020
vidya-ram
pushed a commit
that referenced
this pull request
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.