Schedule fixes #125
Merged
Schedule fixes #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shreyas-satish
commented
Jun 16, 2015
shreyas-satish
commented
- The slot size has been set to 5 minutes in the 'edit' view and 15 minutes in the read-only view.
- The date range for the calendar now accommodates changes in a proposal space's dates.
| first_session_date = Session.query.filter_by(proposal_space=space).order_by("created_at asc").first().start | ||
| last_session_date = Session.query.filter_by(proposal_space=space).order_by("created_at desc").first().start | ||
| from_date = first_session_date if first_session_date.date() < space.date else space.date | ||
| to_date = last_session_date if last_session_date.date() > space.date_upto else space.date_upto |
There was a problem hiding this comment.
How does this work if the dates are several weeks/months apart? Do you get navigation and the ability to drag across weeks?
There was a problem hiding this comment.
Interesting use case; hasn't been covered here. One option is to provide a 'bulk edit' option that remaps the dates of the sessions to the new dates. Also, dragging multiple sessions across weeks or months can be cumbersome.
|
Merging since we need this urgently for Fifthel, but the highlighted concern needs to be examined. |
jace
added a commit
that referenced
this pull request
Apr 6, 2020
jace
added a commit
that referenced
this pull request
Apr 6, 2020
vidya-ram
pushed a commit
that referenced
this pull request
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.