On destroy friendship callback

Gemfile.lock

@@ -1,8 +1,8 @@
 PATH
   remote: .
   specs:
-    has_friendship (1.1.0)
-      rails (>= 4.0.0, < 5.1.0)
+    has_friendship (1.1.1)
+      rails (>= 4.0.0, <= 5.1.0)
       stateful_enum
 
 GEM
@@ -225,4 +225,4 @@ DEPENDENCIES
   tzinfo-data
 
 BUNDLED WITH
-   1.12.5
+   1.13.6

README.md

@@ -158,6 +158,10 @@ def on_friendship_created(friendship)
   ...
 end
 
+def on_friendship_destroyed(friendship)
+  ...
+end
+
 def on_friendship_accepted(friendship)
   ...
 end

has_friendship.gemspec

@@ -15,7 +15,7 @@ Gem::Specification.new do |s|
 
   s.files = Dir["{app,config,db,lib}/**/*", "MIT-LICENSE", "Rakefile", "README.rdoc"]
 
-  s.add_dependency "rails", ['>= 4.0.0', '< 5.1.0']
+  s.add_dependency "rails", ['>= 4.0.0', '<= 5.1.0']
   s.add_dependency "stateful_enum"
 
   s.add_development_dependency "sqlite3"

lib/generators/has_friendship/has_friendship_generator.rb

@@ -17,10 +17,21 @@ def self.next_migration_number(path)
 
   def create_migration_file
     migration_template 'create_friendships.rb',
-                       'db/migrate/create_friendships.rb'
+                       'db/migrate/create_friendships.rb', migration_version: migration_version
     migration_template 'add_blocker_id_to_friendships.rb',
-                       'db/migrate/add_blocker_id_to_friendships.rb'
+                       'db/migrate/add_blocker_id_to_friendships.rb', migration_version: migration_version
     migration_template '../../has_friendship_update/templates/update_friendships.rb',
-                       'db/migrate/update_friendships.rb'
+                       'db/migrate/update_friendships.rb', migration_version: migration_version
   end
+
+  def rails5?
+    Rails.version.start_with? '5'
+  end
+
+  def migration_version
+    if rails5?
+      "[#{Rails::VERSION::MAJOR}.#{Rails::VERSION::MINOR}]"
+    end
+  end
+
 end

lib/generators/has_friendship/templates/add_blocker_id_to_friendships.rb

@@ -1,4 +1,4 @@
-class AddBlockerIdToFriendships < ActiveRecord::Migration
+class AddBlockerIdToFriendships < ActiveRecord::Migration<%= migration_version %>
   def self.up
     add_column :friendships, :blocker_id, :integer, default: nil
   end

lib/generators/has_friendship/templates/create_friendships.rb

@@ -1,4 +1,4 @@
-class CreateFriendships < ActiveRecord::Migration
+class CreateFriendships < ActiveRecord::Migration<%= migration_version %>
   def self.up
     create_table :friendships do |t|
       t.references :friendable, polymorphic: true

lib/generators/has_friendship_update/has_friendship_update_generator.rb

@@ -17,6 +17,16 @@ def self.next_migration_number(path)
 
   def create_migration_file
     migration_template 'update_friendships.rb',
-                       'db/migrate/update_friendships.rb'
+                       'db/migrate/update_friendships.rb', migration_version: migration_version
+  end
+
+  def rails5?
+    Rails.version.start_with? '5'
+  end
+
+  def migration_version
+    if rails5?
+      "[#{Rails::VERSION::MAJOR}.#{Rails::VERSION::MINOR}]"
+    end
   end
 end

lib/generators/has_friendship_update/templates/update_friendships.rb

@@ -1,4 +1,4 @@
-class UpdateFriendships < ActiveRecord::Migration
+class UpdateFriendships < ActiveRecord::Migration<%= migration_version %>
   def self.up
     add_column :friendships, :status_temp, :integer, index: true
     HasFriendship::Friendship.where(status: 'pending').update_all(status_temp: 0)

lib/has_friendship/friendable.rb

@@ -89,6 +89,7 @@ def friends_with?(friend)
       end
 
       def on_friendship_created(*args); end
+      def on_friendship_destroyed(*args); end
       def on_friendship_accepted(*args); end
       def on_friendship_blocked(*args); end
 

lib/has_friendship/friendship.rb

@@ -5,6 +5,10 @@ class Friendship < ActiveRecord::Base
       friend.on_friendship_created(self)
     end
 
+    before_destroy do
+      friendable.on_friendship_destroyed(self)
+    end
+
     enum status: { pending: 0, requested: 1, accepted: 2, blocked: 3 } do
       event :accept do
         transition [:pending, :requested] => :accepted

lib/has_friendship/version.rb

@@ -1,3 +1,3 @@
 module HasFriendship
-  VERSION = "1.1.0"
+  VERSION = "1.1.1"
 end

spec/has_friendship/friendable_spec.rb

@@ -297,5 +297,16 @@
       end
     end
 
+    describe '#on_friendship_destroyed' do
+      context 'when friendship is destroyed' do
+        it 'should be called' do
+          user.friend_request(friend)
+          friendship = find_friendship_record(user, friend)
+          expect(friendship.friendable).to receive(:on_friendship_destroyed)
+          friendship.destroy
+        end
+      end
+    end
+
   end
 end