On destroy friendship callback #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungwoncho
reviewed
May 13, 2017
| @@ -15,7 +15,7 @@ Gem::Specification.new do |s| | |||
|
|
|||
| s.files = Dir["{app,config,db,lib}/**/*", "MIT-LICENSE", "Rakefile", "README.rdoc"] | |||
|
|
|||
| s.add_dependency "rails", ['>= 4.0.0', '< 5.1.0'] | |||
| s.add_dependency "rails", ['>= 4.0.0', '<= 5.1.0'] | |||
There was a problem hiding this comment.
any reasons for version constraint?
| @@ -17,10 +17,21 @@ def self.next_migration_number(path) | |||
|
|
|||
| def create_migration_file | |||
| migration_template 'create_friendships.rb', | |||
| 'db/migrate/create_friendships.rb' | |||
| 'db/migrate/create_friendships.rb', migration_version: migration_version | |||
There was a problem hiding this comment.
Is this something required from Rails 5 and onwards? Could you link me to a source?
There was a problem hiding this comment.
| end | ||
|
|
||
| def rails5? | ||
| Rails.version.start_with? '5' |
There was a problem hiding this comment.
This method seems not future proof. It will stop working in Rails 6.
There was a problem hiding this comment.
|
Closing in favor of #56 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.