Removing Spotlight::HarvestingCompleteMailer.harvest_failed UI call #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that we're uploading via the UI, we don't need to send an email when we fail the save of the OaipmhHarvester object. Instead let's flash the errors and not send an email. Then if the harvester saves, when we run the `Spotlight::Resources::PerformHarvestsJob.perform_later` that can send the email notifying of error. See https://github.com/harvard-lts/CURIOSity/issues/185
phil-plencner-hl
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that we're uploading via the UI, we don't need to send an email when we fail the save of the OaipmhHarvester object. Instead let's flash the errors and not send an email.
Then if the harvester saves, when we run the
Spotlight::Resources::PerformHarvestsJob.perform_laterthat can send the email notifying of error.See https://github.com/harvard-lts/CURIOSity/issues/185
Testing Instructions:
The goal is to submit an OAI PMH Harvester that has invalidate form data.
In the UI, submit a new OAI PMH Harvester without a
set. (This will require removing therequired=trueHTML 5 property on the attribute). When you submit the form with invalid data:Prior to this change, you will see a flash error message and an email will be sent.