Removing Spotlight::HarvestingCompleteMailer.harvest_failed UI call (#33

)

Given that we're uploading via the UI, we don't need to send an email
when we fail the save of the OaipmhHarvester object.  Instead let's
flash the errors and not send an email.

Then if the harvester saves, when we run the
`Spotlight::Resources::PerformHarvestsJob.perform_later` that can send
the email notifying of error.

See https://github.com/harvard-lts/CURIOSity/issues/185

app/controllers/spotlight/resources/oaipmh_harvester_controller.rb

@@ -29,20 +29,19 @@ def create
         Spotlight::Resources::PerformHarvestsJob.perform_later(harvester: harvester, user: current_user)
         flash[:notice] = t('spotlight.resources.oaipmh_harvester.performharvest.success', set: resource_params[:set])
       else
-        Spotlight::HarvestingCompleteMailer.harvest_failed(resource_params[:set], current_exhibit, current_user).deliver_now
-        flash[:error] = "Failed to create harvester for '%{set}'."
+        flash[:error] = "Failed to create harvester for '%{set}'. #{harvester.errors.full_messages.to_sentence}"
       end
       redirect_to spotlight.admin_exhibit_catalog_path(current_exhibit, sort: :timestamp)
     end
-    
+
   private
-    
+
     def upload
       name = resource_params[:custom_mapping].original_filename
-      Dir.mkdir("public/uploads") unless Dir.exist?("public/uploads")  
+      Dir.mkdir("public/uploads") unless Dir.exist?("public/uploads")
       dir = "public/uploads/modsmapping"
       Dir.mkdir(dir) unless Dir.exist?(dir)
-      
+
       path = File.join(dir, name)
       File.open(path, "w") { |f| f.write(resource_params[:custom_mapping].read) }
     end