Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make footer sticky. #35

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Make footer sticky. #35

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c202c8b
Make footer sticky.
rebeccacremona Jan 29, 2024
0b49dfe
Footer should be sibling of main.
rebeccacremona Jan 29, 2024
c9677d8
Move from layout.css to global.css per review.
rebeccacremona Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/caselaw/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
<cap-nav></cap-nav>
<main id="main">
<cap-content-router></cap-content-router>
<cap-footer></cap-footer>
</main>
<cap-footer></cap-footer>
</body>
</html>
11 changes: 11 additions & 0 deletions src/css/layout.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,14 @@
html {
height: 100%;
min-height: 100%;
}

body {
min-height: 100%;
display: grid;
grid-template-rows: auto 1fr auto;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if it would be helpful for me to write a style guide (after everything else critical is written, perhaps) about the conventions and organization strategies for cap static. The layout.css file is specifically intended for layout classes — that are prepended with l-.

For example, l-interiorPage

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 moved!

.l-interiorPage {
display: grid;
grid-template-columns: repeat(4, 1fr);
Expand Down
2 changes: 1 addition & 1 deletion src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
<cap-section-highlight> </cap-section-highlight>
<cap-contact> </cap-contact>
</section>
<cap-footer></cap-footer>
</main>
<cap-footer></cap-footer>
</body>
</html>
Loading