Make footer sticky. #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccacremona
requested review from
mdellabitta
and removed request for
a team
rebeccacremona
force-pushed
the
sticky-footer
branch
from
5a7ce81 to
711e98e
Compare
rebeccacremona
force-pushed
the
sticky-footer
branch
from
711e98e to
0b49dfe
Compare
|
Assigning to @tinykite because I'm way out of my element! (HTML pun intended) |
|
@mdellabitta Yeah, CSS grid is pretty great! Observe that this literally only took one line: |
tinykite
reviewed
Jan 30, 2024
src/css/layout.css
Outdated
Comment on lines
1
to
11
| html { | ||
| height: 100%; | ||
| min-height: 100%; | ||
| } | ||
|
|
||
| body { | ||
| min-height: 100%; | ||
| display: grid; | ||
| grid-template-rows: auto 1fr auto; | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm wondering if it would be helpful for me to write a style guide (after everything else critical is written, perhaps) about the conventions and organization strategies for cap static. The layout.css file is specifically intended for layout classes — that are prepended with l-.
For example, l-interiorPage
|
This is great! My only suggestion would be the move the global root selector classes you wrote (for body and html) to |
tinykite
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technique from https://developer.mozilla.org/en-US/docs/Web/CSS/Layout_cookbook/Sticky_footers
Before:
After:
Even though only the 404 page is affected at present, since it is the only short page, I moved the footer on the landing page and on the caselaw page, so that on every page, it is a sibling of
maininstead of a child ofmain, so that this CSS would work properly there, had they been shorter. (The footer was already a sibling ofmainon the gallery and about pages).With this change, an empty page,
looks like
instead of
