Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add background replacement, rename some commands, improve BG script preview #119

Merged
merged 14 commits into from
Apr 5, 2023
Merged

Add background replacement, rename some commands, improve BG script preview #119

merged 14 commits into from
Apr 5, 2023

Conversation

jonko0493
Copy link
Member

Closes #87. Closes #57.

The primary thrust of this PR is adding full background replacement. It does that successfully!

A few other things:

  • Renames some commands that needed renaming
  • Renames the BG types per lib changes to make them more clear
  • Improves the script preview to correctly display dual screen BGs and respect BG_SCROLL

@jonko0493 jonko0493 requested a review from WiIIiam278 April 4, 2023 23:03
@jonko0493 jonko0493 self-assigned this Apr 4, 2023
WiIIiam278
WiIIiam278 approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@WiIIiam278 WiIIiam278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice and works a charm for me!!

@jonko0493 jonko0493 merged commit 5b5e56f into haroohie-club:main Apr 5, 2023
@jonko0493 jonko0493 deleted the BgReplacement branch April 5, 2023 00:20
@jonko0493 jonko0493 mentioned this pull request Nov 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WiIIiam278 WiIIiam278 WiIIiam278 approved these changes

Assignees

@jonko0493 jonko0493

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Background replacement Rename commands
2 participants
@jonko0493 @WiIIiam278