Switch to github.com/jacobsa/go-serial

[blockmurder]

In order to support custom baud rates (e.g. for P4 Dragon, see #3) we should switch from https://github.com/tarm/serial to https://github.com/jacobsa/go-serial/

I initially proposed https://github.com/mikepb/go-serial but as @martinhpedersen stated correctly in #3:

I think the best solution would be to find a pure Go package, because that would allow us to cross compile more easily. I belive the current serial package used also uses cgo, so it's not a very high priority. But it would certainly be nice to get rid of all C dependencies eventually.

Seems like jacobsa/go can do without cgo: https://github.com/jacobsa/go-serial/blob/15cf729a72d49e837fa047a4142fa6e4d5ab45a1/serial/open_linux.go#L14

[blockmurder]

@martinhpedersen Currently, ptc-go uses tarm/serial, located in pat/vendor/github.com/tarm/serial
Would you prefere if ptc-go would use its own include directory like
ax25 wl2k-go/transport/ax25/vendor/github.com/tarm ?

[martinhpedersen]

@blockmurder - Regarding /vendor/. We will need to migrate to using Go Modules soon, so I don't think we should do any changes to the vendor structure right now.

I will have a look at github.com/jacobsa/go-serial. Thanks :)

[harenber]

I think we can close this issue now, after a lot of checking libraries, I ended up using https://github.com/albenik/go-serial which turned out to be stable, supported the baudrate and seems to be pure Go.

[xylo04]

https://github.com/albenik/go-serial currently doesn't compile on Darwin/OS X. I have a PR in to fix that, but @albenik hasn't responded to the other PR in that repo for several months and may be inactive.

[harenber]

@xylo04 Indeed the project doesn't show much activity anymore. Would you have the time to take up the reponsibility and fork the code and take care of that?

[xylo04]

I hesitate to commit to maintaining a fork. Let me give it some thought.

I was able to make that PR through whack-a-mole hacking, but I don't really deeply understand what this code does. If you believe golang/go#42241 (comment), albenik's approach of recreating the syscall bindings is unsupported, and it should be using the syscall package directly.

[xylo04]

https://github.com/albenik/go-serial was forked from https://github.com/bugst/go-serial which is still active, so we could consider looking at that.

[harenber]

I think I tried this one (bugst) and there was a show-stopper somewhere. I do not really remember, I tried a couple of serial libraries and nearly all had the problem that they did not support this non-standard baud rate we need for the P4 modems. But anyway, it's definitely worth a (2nd) look.