Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken on Darwin/macOS #15

Closed
xylo04 opened this issue Oct 7, 2020 · 1 comment · Fixed by #17
Closed

Broken on Darwin/macOS #15

xylo04 opened this issue Oct 7, 2020 · 1 comment · Fixed by #17

Comments

@xylo04
Copy link
Contributor

xylo04 commented Oct 7, 2020

In PR la5nta/pat#222, I noticed this module was recently broken.

According to ory/dockertest#212 (comment), zsyscall_darwin.go should not be using unix.SYS_IOCTL, but instead

unix.IoctlGetTermios and unix.IoctlSetTermios. Direct system calls are considered unsupported by the Darwin maintainers.
xylo04 added a commit to xylo04/pat that referenced this issue Oct 7, 2020
@xylo04
Pin golang sys version
b513a57 
This should be a temporary workaround for albenik/go-serial#15
@martinhpedersen martinhpedersen mentioned this issue Oct 15, 2020
Merged
@xylo04
Copy link
Contributor Author

xylo04 commented Oct 28, 2020

I tracked this down to a system call generator script in golang: golang/go#42241

This was referenced Oct 28, 2020
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modify generated darwin syscall
1 participant
@xylo04