Remove GlobalEdge
#1999
Merged
Remove GlobalEdge
#1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validation checks that contains this code already have redundant code that does the same validation based on `Curve`. This was part of the transition from `GlobalEdge` to `Curve`, which is about to conclude.
Replacing the global form is no longer necessary, as `GlobalEdge` no longer fulfills any role.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured this would be the crowning achievement of #1937, but as it turns out,
Curvewas already able to replaceGlobalEdgefully. This doesn't mean the limitation is lifted yet (this requires some non-trivial changes to the approximation code that I've been working on), but at least it means we finished the transition away fromGlobalEdgeand got rid of all that redundant code.