Fix logscale limit updates #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cale axes, adjusting to new data limits, see issue #381
lukashergt
commented
Apr 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #383 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 36 36
Lines 3052 3056 +4
=========================================
+ Hits 3052 3056 +4 ☔ View full report in Codecov by Sentry. |
williamjameshandley
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Nice work @lukashergt. I can confirm that fixes my (less minimal) use case. Many thanks!
| @@ -356,7 +356,7 @@ def plot_2d(self, axes=None, *args, **kwargs): | |||
| if np.isinf(self[x]).any(): | |||
| warnings.warn(f"column {y} has inf values.") | |||
| selfxy = self[[x, y]] | |||
| selfxy = self.replace([-np.inf, np.inf], np.nan) | |||
| selfxy = selfxy.replace([-np.inf, np.inf], np.nan) | |||
AdamOrmondroyd
pushed a commit
to AdamOrmondroyd/anesthetic
that referenced
this pull request
May 28, 2024
* test that limits get accurately updated by successive plots with logscale axes, adjusting to new data limits, see issue handley-lab#381 * fix typo from PR handley-lab#324 * bump version to 2.8.10 * update logscale plot limits to datalimits at the end, making use of `ax.dataLim`
AdamOrmondroyd
added a commit
that referenced
this pull request
Jun 24, 2024
* allow matplotlib 3.9 * bump version to 2.8.10 * Fix logscale limit updates (#383) * test that limits get accurately updated by successive plots with logscale axes, adjusting to new data limits, see issue #381 * fix typo from PR #324 * bump version to 2.8.10 * update logscale plot limits to datalimits at the end, making use of `ax.dataLim` * Fix macOS CI (#385) * attempt at fixing macOS CI by brew installing hdf5 * update from `miniconda@v2` to `miniconda@v3` * bump version to 2.8.11 * try newer `tables` version, which was previously restricted to 3.8.0 in #379 * Revert "attempt at fixing macOS CI by brew installing hdf5" This reverts commit 968bdb3. * Reapply "attempt at fixing macOS CI by brew installing hdf5" This reverts commit 204014a. Seems like this is needed after all, otherwise macOS is struggling to find a local HDF5. --------- Co-authored-by: Will Handley <[email protected]> * Fix to `color='C2'` plot_2d error post pandas 2 (#382) * Added failing test * bump version to 2.8.10 * Get color from self.color * Update README.rst * Update _version.py * Update README.rst * Update _version.py --------- Co-authored-by: Lukas Hergt <[email protected]> * bump version to 2.8.10 * bump version to 2.8.11 * bump version to 2.8.13 --------- Co-authored-by: Lukas Hergt <[email protected]> Co-authored-by: Will Handley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #381, where subsequent plots on logarithmic axes did not correctly update the plotting limits.
Fixes #381
Checklist:
flake8 anesthetic tests)pydocstyle --convention=numpy anesthetic)python -m pytest)