Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the list of cidrs and hosts configurable #9

Closed
wants to merge 4 commits into from

Conversation

hamstah
Copy link
Contributor

@hamstah hamstah commented Dec 19, 2018

No description provided.

@hamstah
Copy link
Contributor Author

hamstah commented Mar 21, 2019

Closing this as the project doesn't seem active anymore, I'm maintaining a fork at https://github.com/hamstah/paranoidhttp with those changes

@hamstah hamstah closed this Mar 21, 2019
@Songmu
Copy link
Collaborator

Songmu commented Mar 21, 2019

Sorry for not responding. I am one of the maintainers of this package.

What is your intention about this change?

I think it's convenient to be configurable, but without a use case, it may not make much sense.

@hamstah
Copy link
Contributor Author

hamstah commented Mar 21, 2019

No worries. I use it to whitelist private IPs which needs to be available to the client. The use case is webhooks delivery where some of the webhooks are internal IPs.

@Songmu
Copy link
Collaborator

Songmu commented Mar 21, 2019

I see.

But, it is incompatible change so, could you consider to adopt "functional option pattern"?

Or I may create another fix based on your change.

ref. https://commandcenter.blogspot.com/2014/01/self-referential-functions-and-design.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants