-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the list of cidrs and hosts configurable #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Songmu
changed the title
Make the list of cidrs and hosts configurable
WIP: Make the list of cidrs and hosts configurable
Mar 25, 2019
Now we can configure forbidden and allow hosts and CIDRs in constructor using following functional option without breaking changes. @hamstah
Could you try it? |
Songmu
changed the title
WIP: Make the list of cidrs and hosts configurable
Make the list of cidrs and hosts configurable
Apr 2, 2019
Songmu
added a commit
that referenced
this pull request
Apr 2, 2019
## [v0.2.0](v0.1.0...v0.2.0) (2019-04-02) * Make the list of cidrs and hosts configurable [#10](#10) ([Songmu](https://github.com/Songmu))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #9 implementation. I use functional option pattern for backward compatibility.