Fix: Prevent console-warning on correct plugin config #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t's core nowadays, hence it can be hard-coded as active.
…ixed. Shows only if it detects something.
sweco-semara
changed the title
jacobwod
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
Confirmed working, I've had this in production for about two weeks. Does not solve the bookmark vs bookmarks issue you mention @sweco-semara, but I think you've solved it elsewhere already.
Hallbergs
approved these changes
Sep 5, 2023
sweco-semara
deleted the
fix/1390-prevent-invalid-plugin-config-warning
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git cherry-pick of @jacobwod existing fixes to prevent "false flag" console logging re. invalid plugin config
Fixes #1390
Cherry picks: