You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hajk backend map config examples contains an invalid plugin configuration. Specifically "bookmark" plugin, which does not exist.
To Reproduce
Use either .NET or NodeJS backend-based config with backend/mapservice/App_Data/map_1.json or new-client/public/simpleMapConfig.json as base
Open browser console
(Re-)load the map
Check browser console
Expected behavior
Quiet/empty console on using Hajk-supplied config examples. (Currently also expects an empty warning, see also #1390, but the point in this bug report is that a specific error report is not expected after reproducing per above...)
Actual
Console warning:
App.js:396 The map configuration contains unavailable plugins: bookmark. Please check your map config and buildConfig.json.
Root Cause Analysis
I think this might be a Hajk 2 leftover in the demo/example config? The bookmarks plugin in Hajk 3 seems to be introduced in #655 and from what I can see it has always been named with a plural "s"?
Suggested Solution
Simplest fix is probably to just rename "bookmark" to "boomarks" in both of the following example configs?
.NET backend sample config map_1.json L437 in current master
NodeJS backend sample config map_1.json L440 in current master
(Not backwards compatible as a new plugin would then start showing in the demos, so another way to get rid of the warning is to just remove the whole plugin/tool config for "bookmark" from both files... But I think Hajk does not need to maintain a status quo for demo configs?)
The text was updated successfully, but these errors were encountered:
I absolutely agree. In fact, I've fixed it (outside of upstream though, so you had almost no chance finding it) in b10b50a and 89cdefa.
The first commit ensures that preset is forced into the array we check against. preset is a special case as it can exist in the map config object but can never be a part of the activeTools object and will thus always show up as a warning without this.
The second commit ensures that we don't print an empty message.
Feel free to implement your solution though, as mine was never part of the main branch. Thanks.
Hajk backend map config examples contains an invalid plugin configuration. Specifically "bookmark" plugin, which does not exist.
To Reproduce
backend/mapservice/App_Data/map_1.json
ornew-client/public/simpleMapConfig.json
as baseExpected behavior
Quiet/empty console on using Hajk-supplied config examples. (Currently also expects an empty warning, see also #1390, but the point in this bug report is that a specific error report is not expected after reproducing per above...)
Actual
Console warning:
Root Cause Analysis
I think this might be a Hajk 2 leftover in the demo/example config? The bookmarks plugin in Hajk 3 seems to be introduced in #655 and from what I can see it has always been named with a plural "s"?
Suggested Solution
Simplest fix is probably to just rename "bookmark" to "boomarks" in both of the following example configs?
(Not backwards compatible as a new plugin would then start showing in the demos, so another way to get rid of the warning is to just remove the whole plugin/tool config for "bookmark" from both files... But I think Hajk does not need to maintain a status quo for demo configs?)
The text was updated successfully, but these errors were encountered: