Use go-fsimpl to read from datasources #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairyhenderson
force-pushed
the
read-with-gofsimpl
branch
from
17b51b4
to
8bcc8d0
Compare
hairyhenderson
force-pushed
the
read-with-gofsimpl
branch
from
8bcc8d0
to
dd95193
Compare
hairyhenderson
force-pushed
the
read-with-gofsimpl
branch
4 times, most recently
from
a0ede90
to
c46fd9f
Compare
hairyhenderson
force-pushed
the
read-with-gofsimpl
branch
2 times, most recently
from
e30457b
to
e578b10
Compare
hairyhenderson
force-pushed
the
read-with-gofsimpl
branch
from
e578b10
to
df51841
Compare
hairyhenderson
force-pushed
the
read-with-gofsimpl
branch
6 times, most recently
from
66aa00d
to
00daaa5
Compare
hairyhenderson
force-pushed
the
read-with-gofsimpl
branch
from
00daaa5
to
29c372f
Compare
hairyhenderson
force-pushed
the
read-with-gofsimpl
branch
4 times, most recently
from
f05adbe
to
e1e6df6
Compare
hairyhenderson
force-pushed
the
read-with-gofsimpl
branch
2 times, most recently
from
0392409
to
6794c5e
Compare
hairyhenderson
force-pushed
the
read-with-gofsimpl
branch
from
6794c5e
to
41efbd2
Compare
hairyhenderson
force-pushed
the
read-with-gofsimpl
branch
from
41efbd2
to
36a1df0
Compare
hairyhenderson
force-pushed
the
read-with-gofsimpl
branch
4 times, most recently
from
f544869
to
b872159
Compare
hairyhenderson
force-pushed
the
read-with-gofsimpl
branch
2 times, most recently
from
7a5c826
to
1f75257
Compare
hairyhenderson
force-pushed
the
read-with-gofsimpl
branch
2 times, most recently
from
91c8d7b
to
ee4118e
Compare
hairyhenderson
changed the title
hairyhenderson
force-pushed
the
read-with-gofsimpl
branch
from
ee4118e
to
63c13c0
Compare
|
almost there - looks like some Windows compatibility issues still 😬 |
Signed-off-by: Dave Henderson <[email protected]>
hairyhenderson
force-pushed
the
read-with-gofsimpl
branch
from
63c13c0
to
f374e9f
Compare
Signed-off-by: Dave Henderson <[email protected]>
Signed-off-by: Dave Henderson <[email protected]>
hairyhenderson
force-pushed
the
read-with-gofsimpl
branch
from
63c4832
to
f20e904
Compare
Signed-off-by: Dave Henderson <[email protected]>
hairyhenderson
force-pushed
the
read-with-gofsimpl
branch
from
b337002
to
340840b
Compare
Signed-off-by: Dave Henderson <[email protected]>
Signed-off-by: Dave Henderson <[email protected]>
|
Wow do I ever dislike dealing with Windows paths... This is not perfect, but all the tests pass now, so I think it's ready to merge. There will be a bunch of cleanup/refactoring PRs to follow before 4.0 gets cut, but I want to get a prerelease out ASAP to see if I can get these changes tested in the wild... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace datasource code with go-fsimpl.
Note - this will go in v4 since it breaks compatibility by removing support for certain datasource types. It also unifies the URL formats in ways that may be slightly incompatible with v3. My hope is to reduce that impact, but it may not be possible for every datasource type.