vaultfs: auth improvements #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairyhenderson
force-pushed
the
fix-vaultfs-auth-issues
branch
from
00d67d9
to
77cae83
Compare
Signed-off-by: Dave Henderson <[email protected]>
hairyhenderson
force-pushed
the
fix-vaultfs-auth-issues
branch
from
77cae83
to
386e783
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During hairyhenderson/gomplate#1336 I realized that the
vaultauth.EnvAuthMethodcauses tokens to be revoked, when they shouldn't be, because it wasn't implementing theauthLogouterinterface.I've fixed this up, and altered that interface to be able to pass a context (it's only used here, so that's safe).
This also tweaks the error handling when a GET fails and falls back to LIST - if both fail, the first error is returned since that might make a bit more sense.
This also exports
vaultauth.CompositeAuthMethodfor easier auth method composition.