Fix bug generating top-level links for standard library crates (e.g. ::std).
#56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orium
commented
Jan 28, 2021
| @@ -182,6 +191,12 @@ impl fmt::Display for FQIdentifier { | |||
| } | |||
| } | |||
|
|
|||
| impl fmt::Debug for FQIdentifier { | |||
There was a problem hiding this comment.
If we simply derived Debug the output from unit test failures were completely unreadable.
There was a problem hiding this comment.
Do you have an example of such an output?
There was a problem hiding this comment.
With this implementation the output is something like crate::foo::bar. With auto derivation it is FQIdentifier { anchor: Crate, path_shared: ["foo", "bar"], path_end: 2 }. This is specially confusing when path_end does truncate the path_shared to a shorter length.
…`::std`). Links to standard library crates themselves (e.g. `::std`, or `::alloc`) were not working.
This was not a bug the code ever triggered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to standard library crates themselves (e.g.
::std, or::alloc) were not working.