Fix bug handling images with links. #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit links with images would get corrupted: the image would simply be removed. This commit changes the link handling logic to not care about what's inside the text in a link and simply copy it verbatim from the source markdown, avoiding this and other similar problems were things are nested inside a link's text.
|
Rebased on master. Should be ready for review now. |
hadronized
requested changes
Mar 3, 2021
…scape logic. This avoids potential issues in not escaping everything that needs escaping.
|
Is this getting merged? I am running into this issue as well. Thanks. |
|
Hi @phaazon. This project had been pretty low in activity in the last few months. Let me know if you no longer want to maintain it. I'm happy to fork the project, work on it, and maintain it if you no longer wish to do so. |
|
I've created my own project to create READMEs from rustdoc. It addresses the issue in this PR as well as PR #56 and other bugs: https://github.com/orium/cargo-rdme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess as one of the first users I would get one of the first bugs 🙂
Before this commit links with images would get corrupted: the image would simply be removed.
This PR changes the link handling logic to not care about what's inside the text in a link and simply copy it verbatim from the source markdown, avoiding this and other similar problems were things are nested inside a link's text.
Merge #53 before this, so I can add an integration test for this.✓