Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an automated DPO/CLA workflow #936

Closed
dhess opened this issue Apr 11, 2023 · 3 comments · Fixed by #987
Closed

Add an automated DPO/CLA workflow #936

dhess opened this issue Apr 11, 2023 · 3 comments · Fixed by #987

Comments

@dhess
Copy link
Member

dhess commented Apr 11, 2023

Ref:

@dhess
Copy link
Member Author

dhess commented May 11, 2023

This should be added org-wide, actually. GitHub supports this, but it might be a bit too limited/restrictive for our needs: https://docs.github.com/en/actions/using-workflows/required-workflows

@dhess
Copy link
Member Author

dhess commented May 11, 2023

There may be some issues enabling this feature while using merge queues:

Possible solutions:

Sigh, GitHub Discussions won't auto-expand a rolled-up discussion when you link to a comment that is not shown in the initial fetch, so here is the content of the comment I linked above, for reference:

I currently work around this issue by skipping the action when the event is merge_group and use [github status action](https://github.com/marketplace/actions/github-status-action) to report success status for the required checks.

  mock_report:
    runs-on: ubuntu-latest
    if: ${{ github.event_name == 'merge_group' }}
    steps:
      - uses: actions/checkout@v2
      - name: Skip UI Tests
        uses: Sibz/github-status-action@v1
        with:
          authToken: ${{ secrets.GITHUB_TOKEN }}
          context: 'UI Tests'
          description: 'Skipped for merge queue'
          state: 'success'
          sha: ${{github.event.merge_group.head.sha || github.sha}}

@dhess
Copy link
Member Author

dhess commented May 14, 2023

The hosted DCO suffers from occasional failures, causing dependent CIs to stall/fail: dcoapp/app#162

Therefore, I think it makes sense for host to host our own.

dhess added a commit that referenced this issue May 14, 2023
Closes #936

Note that this workflow currently triggers on merge queue entries, but
I'm not sure whether that functionality will work, because the Probot
app upon which it's based doesn't have explicit support for that.
However, it may not matter in practice, as presumably any PR that
enters the merge queue will have already passed the DCO check in the
first place.

For now, this check isn't a required job, only advisory, so it won't
block anything from merging, in any case.
dhess added a commit that referenced this issue May 14, 2023
Closes #936

Note that this workflow currently triggers on merge queue entries, but
I'm not sure whether that functionality will work, because the Probot
app upon which it's based doesn't have explicit support for that.
However, it may not matter in practice, as presumably any PR that
enters the merge queue will have already passed the DCO check in the
first place.

For now, this check isn't a required job, only advisory, so it won't
block anything from merging, in any case.
dhess added a commit that referenced this issue May 14, 2023
Closes #936

Note that this workflow currently triggers on merge queue entries, but
I'm not sure whether that functionality will work, because the Probot
app upon which it's based doesn't have explicit support for that.
However, it may not matter in practice, as presumably any PR that
enters the merge queue will have already passed the DCO check in the
first place.

For now, this check isn't a required job, only advisory, so it won't
block anything from merging, in any case.

Signed-off-by: Drew Hess <[email protected]>
dhess added a commit that referenced this issue May 14, 2023
Closes #936

Note that this workflow currently triggers on merge queue entries, but
I'm not sure whether that functionality will work, because the Probot
app upon which it's based doesn't have explicit support for that.
However, it may not matter in practice, as presumably any PR that
enters the merge queue will have already passed the DCO check in the
first place.

For now, this check isn't a required job, only advisory, so it won't
block anything from merging, in any case.

Signed-off-by: Drew Hess <[email protected]>
@dhess dhess closed this as completed in 4687f6f May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant