-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an automated DPO/CLA workflow #936
Comments
|
There may be some issues enabling this feature while using merge queues:
Possible solutions:
Sigh, GitHub Discussions won't auto-expand a rolled-up discussion when you link to a comment that is not shown in the initial fetch, so here is the content of the comment I linked above, for reference:
|
The hosted DCO suffers from occasional failures, causing dependent CIs to stall/fail: dcoapp/app#162 Therefore, I think it makes sense for host to host our own. |
Closes #936 Note that this workflow currently triggers on merge queue entries, but I'm not sure whether that functionality will work, because the Probot app upon which it's based doesn't have explicit support for that. However, it may not matter in practice, as presumably any PR that enters the merge queue will have already passed the DCO check in the first place. For now, this check isn't a required job, only advisory, so it won't block anything from merging, in any case.
Closes #936 Note that this workflow currently triggers on merge queue entries, but I'm not sure whether that functionality will work, because the Probot app upon which it's based doesn't have explicit support for that. However, it may not matter in practice, as presumably any PR that enters the merge queue will have already passed the DCO check in the first place. For now, this check isn't a required job, only advisory, so it won't block anything from merging, in any case.
Closes #936 Note that this workflow currently triggers on merge queue entries, but I'm not sure whether that functionality will work, because the Probot app upon which it's based doesn't have explicit support for that. However, it may not matter in practice, as presumably any PR that enters the merge queue will have already passed the DCO check in the first place. For now, this check isn't a required job, only advisory, so it won't block anything from merging, in any case. Signed-off-by: Drew Hess <[email protected]>
Closes #936 Note that this workflow currently triggers on merge queue entries, but I'm not sure whether that functionality will work, because the Probot app upon which it's based doesn't have explicit support for that. However, it may not matter in practice, as presumably any PR that enters the merge queue will have already passed the DCO check in the first place. For now, this check isn't a required job, only advisory, so it won't block anything from merging, in any case. Signed-off-by: Drew Hess <[email protected]>
Ref:
The text was updated successfully, but these errors were encountered: