Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dco app doesn't run in merge queues #199

Open
Licenser opened this issue Feb 10, 2023 · 3 comments
Open

dco app doesn't run in merge queues #199

Licenser opened this issue Feb 10, 2023 · 3 comments

Comments

@Licenser
Copy link

Hi,

it seems like the DCO app doesn't run as part of merge queues, it would be nice to be able to do that so the two features are compatible with each other:

grafik

@jcwchen
Copy link

jcwchen commented Feb 14, 2023

I also bumped into this issue that our required DCO blocked merge queue and I have no idea how to make DCO run in our merge queue. Looking forward to a solution. Thanks!

@jcwchen
Copy link

jcwchen commented Jul 7, 2023

I would like to share a workaround in case someone keenly wants to use merge queue with required DCO: create a dummy DCO workflow and set it always passed for merge_group. For instance, https://github.com/onnx/onnx/blob/main/.github/workflows/dco_merge_group.yml. Then it won't check DCO in merge queue and always pass.

I learned it from others who pointed to this issue (thank you for the idea!).

@brooksmtownsend
Copy link

Ran into this with wasmCloud and we're following the same convention as the other projects, but this would be great to resolve to avoid the workaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants