-
-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark civic tech structure 3895 #3927
Mark civic tech structure 3895 #3927
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Availability: Tuesday and Thursday evenings |
@bzzz-coding You asked to review this issue. But your ETA that you mentioned has passed. Gentle reminder to either review it or remove yourself as a reviewer |
I'm sorry I've been very sick this past week. Here's my updated ETA: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RyanGehris Thanks for working on this issue and asking questions in the comments to clarify the task!
I noticed that on line 61 you have changed the status
from Active
to Completed
, but in issue #3895, the instruction uses Complete
. (status: Complete
)
Could you please make this edit? Thank you!
…yanGehris/website into mark-civic-tech-structure-3895
@bzzz-coding Thank you for catching that. I was confused because the other "Completed" projects displayed on the website had a status of "Completed", but the ticket does say to change the status to "Complete". I just made the changes. I hope you feel better soon. |
@RyanGehris Thank you! And thanks for catching that -- I just opened a few files and noticed the same thing. The files below currently have
@hackforla/website Could someone help us clarify the instruction in issue #3895? Should the status be updated to |
Hello @bzzz-coding and @RyanGehris, for the sake of consistency, please use |
Thank you @jdingeman @bzzz-coding I updated the status from "Complete" to "Completed". It is ready for review when you are available. |
…yanGehris/website into mark-civic-tech-structure-3895
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RyanGehris Thanks for working on this issue! Everything looks good!
Thank you for bringing up consistency concerns in the comments and being so diligent!
availability: 2/9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @RyanGehris - great job on your first issue! You are committing from/to the correct branches, and the changes are clean and complete. But also>>> it is great that you and @bzzz-coding are paying attention to details, and not just following the issue but going beyond to make sure the changes are consistent and make sense. Well done
Fixes #3895
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied