Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark civic tech structure 3895 #3927

Merged
merged 19 commits into from
Feb 10, 2023

Conversation

RyanGehris
Copy link
Member

Fixes #3895

What changes did you make and why did you make them ?

  • updated status of civic tech structure to complete
  • updated visibility of civic tech structure to false
  • Made these changes to reflect the current status of the project

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Screenshot 2023-02-02 at 5 12 11 PM

Visuals after changes are applied

Screenshot 2023-02-02 at 5 12 02 PM

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b RyanGehris-mark-civic-tech-structure-3895 gh-pages
git pull https://github.com/RyanGehris/website.git mark-civic-tech-structure-3895

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.25pt Can be done in 0.5 to 1.5 hours labels Feb 3, 2023
@bzzz-coding bzzz-coding self-requested a review February 3, 2023 01:27
@bzzz-coding
Copy link
Member

Availability: Tuesday and Thursday evenings
ETA: By end of day 2/3/23

@ExperimentsInHonesty
Copy link
Member

@bzzz-coding You asked to review this issue. But your ETA that you mentioned has passed. Gentle reminder to either review it or remove yourself as a reviewer

@bzzz-coding
Copy link
Member

I'm sorry I've been very sick this past week. Here's my updated ETA:
ETA: By end of day 2/6/23

Copy link
Member

@bzzz-coding bzzz-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RyanGehris Thanks for working on this issue and asking questions in the comments to clarify the task!

I noticed that on line 61 you have changed the status from Active to Completed, but in issue #3895, the instruction uses Complete. (status: Complete)
Could you please make this edit? Thank you!

@RyanGehris
Copy link
Member Author

@bzzz-coding Thank you for catching that. I was confused because the other "Completed" projects displayed on the website had a status of "Completed", but the ticket does say to change the status to "Complete". I just made the changes. I hope you feel better soon.

@bzzz-coding
Copy link
Member

bzzz-coding commented Feb 7, 2023

@bzzz-coding Thank you for catching that. I was confused because the other "Completed" projects displayed on the website had a status of "Completed", but the ticket does say to change the status to "Complete". I just made the changes. I hope you feel better soon.

@RyanGehris Thank you! And thanks for catching that -- I just opened a few files and noticed the same thing. The files below currently have status: Completed.

  • ems-triage-tracker.md
  • heart.md
  • hellogov.md
  • metro-ontime.md
  • public-tree-map.md
  • undebate.md
  • work-for-la.md

@hackforla/website Could someone help us clarify the instruction in issue #3895? Should the status be updated to Complete or Completed? Many thanks!

@jdingeman
Copy link
Member

Hello @bzzz-coding and @RyanGehris, for the sake of consistency, please use Completed

@RyanGehris
Copy link
Member Author

Thank you @jdingeman

@bzzz-coding I updated the status from "Complete" to "Completed". It is ready for review when you are available.

Copy link
Member

@bzzz-coding bzzz-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RyanGehris Thanks for working on this issue! Everything looks good!
Thank you for bringing up consistency concerns in the comments and being so diligent!

@t-will-gillis t-will-gillis self-requested a review February 9, 2023 22:43
@t-will-gillis
Copy link
Member

availability: 2/9
eta: 2/9 7 pm

Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RyanGehris - great job on your first issue! You are committing from/to the correct branches, and the changes are clean and complete. But also>>> it is great that you and @bzzz-coding are paying attention to details, and not just following the issue but going beyond to make sure the changes are consistent and make sense. Well done

@blulady blulady merged commit bd2a39f into hackforla:gh-pages Feb 10, 2023
@RyanGehris RyanGehris deleted the mark-civic-tech-structure-3895 branch February 15, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark Civic Tech Structure as Completed and change visibility to False
6 participants