Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Civic Tech Structure as Completed and change visibility to False #3895

Closed
2 tasks done
ExperimentsInHonesty opened this issue Jan 30, 2023 · 6 comments · Fixed by #3927
Closed
2 tasks done

Mark Civic Tech Structure as Completed and change visibility to False #3895

ExperimentsInHonesty opened this issue Jan 30, 2023 · 6 comments · Fixed by #3927
Assignees
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours Status: Updated No blockers and update is ready for review

Comments

@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Jan 30, 2023

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page.
  2. Please make sure you have read our Hack for LA Contributing Guide before you claim/start working on an issue.

Overview

We want to mark the Civic Tech Structure project as Complete and make it not visible on the site

  • our website accurately reflects the status (Active, Complete, or On Hold) of our projects,
  • and visitors to our website can know the status of our projects.

Action Items

In _projects/, change the following for Civic Tech Structure from

  • Status
    status: Active
    
    to
    status: Complete
    
  • Visibility
    visible: true
    
    to
    visible: false
    

Resources/Instructions

@ExperimentsInHonesty ExperimentsInHonesty added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jan 30, 2023
@RyanGehris RyanGehris self-assigned this Feb 2, 2023
@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Hi @RyanGehris, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@RyanGehris
Copy link
Member

Availability: Feb 2nd from 3-9
ETA: End of day Feb 2nd

@RyanGehris
Copy link
Member

I am waiting on confirmation for the following question:

Should the status be changed to "Complete" or "On Hold"? The overview and first check point state that it should be changed to "Complete", but the third bullet point says it should be placed "On Hold"

Won't changing the visibility to false cause users to not be able to see the project or navigate to the project's page? I think that once visibility is changed to false, the real check would be to see if the project card is removed from the page.

@MattPereira
Copy link
Contributor

@ExperimentsInHonesty I removed the last action item you wrote

because it doesn't make sense given that the first action item is to change status: to Complete and the second action item is to set visibility: to false which would make completing the last action item impossible

@MattPereira
Copy link
Contributor

MattPereira commented Feb 3, 2023

@RyanGehris I think you are spot on with your plan to verify visible : false by ensuring the Civic Tech Structure project card no longer appears on the projects page

@github-actions github-actions bot added the Status: Updated No blockers and update is ready for review label Feb 3, 2023
@ExperimentsInHonesty
Copy link
Member Author

Both items were changed.

visible: false
status: Completed

Good Job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours Status: Updated No blockers and update is ready for review
Projects
Development

Successfully merging a pull request may close this issue.

3 participants