Update environmental-impact.yml

[RobenusW]

Fixes #2830

What changes did you make and why did you make them ?

-Changed "content" to "content-type"
-Removed "type: icon"
-I did this because I followed what the issue said to change

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Visuals after changes are applied

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b hackforla-RobenusW-patch-1 gh-pages
git pull https://github.com/hackforla/website.git RobenusW-patch-1

[tamara-snyder]

Hi @RobenusW, please add the issue number this PR relates to in the description so that the bot can add appropriate labels and reviewers can view the issue.

[lilyarj]

@RobenusW please add the issue number at the top so we can review this pr :)

Hi @RobenusW, please add the issue number this PR relates to in the description so that the bot can add appropriate labels and reviewers can view the issue.

[RobenusW]

Hi @RobenusW, please add the issue number this PR relates to in the description so that the bot can add appropriate labels and reviewers can view the issue.

Sorry about that, I didn't read the instructions properly, I also just added the image after I realized I didn't follow the correct steps. Please tell me if there is anything getting in the way of merging.

[RobenusW]

@RobenusW please add the issue number at the top so we can review this pr :)

Hi @RobenusW, please add the issue number this PR relates to in the description so that the bot can add appropriate labels and reviewers can view the issue.

Sorry about that, I didn't read the instructions properly, I also just added the image after I realized I didn't follow the correct steps. Please tell me if there is anything getting in the way of merging.

[blulady]

The changes look great but the branch name doesn't follow our typical scheme. You can read about standard scheme here

[lilyarj]

@RobenusW Also just as a note please only screenshot changes if changed have been made to the website, so no pictures of code are needed

[RobenusW]

The changes look great but the branch name doesn't follow our typical scheme. You can read about standard scheme here

I see. Should I create a new merge request using the correct branch or what should I do? Detailed instructions are much needed.

[RobenusW]

The changes look great but the branch name doesn't follow our typical scheme. You can read about standard scheme here

Ok I realized I am a little confused. I thought a created a new branch for this issue

The changes look great but the branch name doesn't follow our typical scheme. You can read about standard scheme here

@RobenusW Also just as a note please only screenshot changes if changed have been made to the website, so no pictures of code are needed

Took them out, thanks for the feedback.

[blulady]

The changes look great but the branch name doesn't follow our typical scheme. You can read about standard scheme here

I see. Should I create a new merge request using the correct branch or what should I do? Detailed instructions are much needed.
@RobenusW
Ok so we have 2 options. You can rename the branch in GitHub or you can rename the branch in your local repo (online guide) To rename your branch locally you would

• get on the branch you are trying to rename (in this case hackforla-RobenusW-patch-1)
• then type git branch -m update-env-impact-yml-3362
• then you can push it up to git, start with git push, git will then provide the appropriate command for you to use
• it will then give you an option of commands, use this one "git push origin HEAD"
• this will create a new pr which I will then approve and merge
  or (directions here)
• go to the main page of the repo (the one that says website)
• click on branches
• then click on the pencil (on the right side)

Personally I would probably change it in github

[RobenusW]

The changes look great but the branch name doesn't follow our typical scheme. You can read about standard scheme here

I see. Should I create a new merge request using the correct branch or what should I do? Detailed instructions are much needed.

Ok so we have 2 options. You can rename the branch in GitHub or you can rename the branch in your local repo (online guide) To rename your branch locally you would

• get on the branch you are trying to rename (in this case hackforla-RobenusW-patch-1)
• then type git branch -m update-env-impact-yml-3362
• then you can push it up to git, start with git push, git will then provide the appropriate command for you to use
• it will then give you an option of commands, use this one "git push origin HEAD"
• this will create a new pr which I will then approve and merge
  or (directions here)
• go to the main page of the repo (the one that says website)
• click on branches
• then click on the pencil (on the right side)

Personally I would probably change it in github

Thanks for your feedback and time. I came across a problem when I was following your steps, it says I can't rename my patch branch because only admins can rename protected branches. What should I do to solve that? Thanks for your detailed steps above.

[BeckettOBrien]

I think that error is happening because the branch you are renaming is on the official hackforla github and not your own fork. This can happen if you accidentally have the hackforla github set as the origin. Can you send the output of git remote -v?

[blulady]

I think that error is happening because the branch you are renaming is on the official hackforla github and not your own fork. This can happen if you accidentally have the hackforla github set as the origin. Can you send the output of git remote -v?

@RobenusW This is probably the issue. If you can't get it working, let me know and we can do a screen share later.

[RobenusW]

• update-env-impact-yml-3362

I see. Thanks for the feedback beyond your duty. I'm going to work through this as much as possible and will update you if I need additional help.

[blulady]

• update-env-impact-yml-3362

I see. Thanks for the feedback beyond your duty. I'm going to work through this as much as possible and will update you if I need additional help.

Totally, but if you spend more than 45 minutes on it, reach out.

[RobenusW]

• update-env-impact-yml-3362

I see. Thanks for the feedback beyond your duty. I'm going to work through this as much as possible and will update you if I need additional help.

Totally, but if you spend more than 45 minutes on it, reach out.

Hey, I tried to fix this issue, but I kinda afraid I am going to mess some things up. Can we schedule a meeting to fix this? Thanks for your patience and help

[blulady]

• update-env-impact-yml-3362

I see. Thanks for the feedback beyond your duty. I'm going to work through this as much as possible and will update you if I need additional help.

Totally, but if you spend more than 45 minutes on it, reach out.

Hey, I tried to fix this issue, but I kinda afraid I am going to mess some things up. Can we schedule a meeting to fix this? Thanks for your patience and help

Absolutely. I have obligations today. You are welcome to attend the Sunday meeting or we can set up a meeting after.

[RobenusW]

I am not able to come to most Sunday meetings, so I am free all week after 4:30, except Friday.

[blulady]

I am not able to come to most Sunday meetings, so I am free all week after 4:30, except Friday.

Hey is that PST or....
I could do Monday at 4:30 PST. Let me know if that works for you.

[RobenusW]

Yes, 4:30 pst works, hope its not too late to respond. Tell me if you can't make it anymore.

[blulady]

It's good. Chat with you tomorrow at 4:30.

[blulady]

Yes, 4:30 pst works, hope its not too late to respond. Tell me if you can't make it anymore.

I sent a zoom link to (what I think is) you on slack.

[blulady]

accidently made this pr from website repo