-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit content field and remove type field from environmental-impact.yml credits file #2830
Comments
This comment was marked as outdated.
This comment was marked as outdated.
Hi @RobenusW, thank you for taking up this issue! Hfla appreciates you :) Do let fellow developers know about your:- You're awesome! P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :) |
Availability: Tuesday-Thursday, Sunday |
How many hours did it take you to finish the pre-work up to and including adding your initial ETA and availability for your good first issue, including attending your first meetings? About 3 weeks |
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. You are receiving this comment because your last comment was before Tuesday, July 5, 2022 at 12:19 AM PST. |
Progress: I am a little behind |
Sorry about the delay, I have just been busy personally, I promise to get back on track |
Progress:Just need to check off dependencies |
@RobenusW I noticed you moved this back to new issue approval. Are you trying to unassign yourself from the issue? |
Submitted PR for this issue. I spent about an hour on this. |
Moving this issue to Prioritized Backlog as changes have not been made and issue hasn't been worked on since September 2022. |
Hi @mademarc, thank you for taking up this issue! Hfla appreciates you :) Do let fellow developers know about your:- You're awesome! P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :) |
Availability: 4/5/2023 |
Hi @StephenTheDev1001, thank you for taking up this issue! Hfla appreciates you :) Do let fellow developers know about your:- You're awesome! P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :) |
Availability: 3/30/2023 |
Prerequisite
Overview
As a developer, I want to edit the content field and remove the type field from a credit's yml file so that redundant code is removed and the code is easier to understand.
Details
Currently, in each credit's yml file, there is a
content
field and atype
field, which contains similar information. Since the fields are redundant, we decided to remove thetype
field.Also, we changed the
content
field to thecontent-type
field to make it clearer what its purpose is. The possible values forcontent-type
field are image, video, or audio; other types of content can be added if necessary. In the future, this will allow developers a way to differentiate easily between different types of content in order to show each credit's media file correctly on the website.Action Items
For the file
_data/internal/credits/environmental-impact.yml
, do the following:Resources/Instructions
File and Code links you will need to work on this issue
Directory to find the page in once you have it in your IDE:
_data/internal/credits/environmental-impact.yml
Click on the links below to see the source file code:
website/_data/internal/credits/environmental-impact.yml
Line 4 in 2443b6c
website/_data/internal/credits/environmental-impact.yml
Line 11 in 2443b6c
The text was updated successfully, but these errors were encountered: