Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit content field and remove type field from environmental-impact.yml credits file #2830

Closed
4 of 5 tasks
Tracked by #2775
tamara-snyder opened this issue Feb 21, 2022 · 15 comments · Fixed by #4346
Closed
4 of 5 tasks
Tracked by #2775
Assignees
Labels
good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Comments

@tamara-snyder
Copy link
Member

tamara-snyder commented Feb 21, 2022

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page.
  2. Please make sure you have read our Hack for LA Contributing Guide before you claim/start working on an issue.

Overview

As a developer, I want to edit the content field and remove the type field from a credit's yml file so that redundant code is removed and the code is easier to understand.

Details

Currently, in each credit's yml file, there is a content field and a type field, which contains similar information. Since the fields are redundant, we decided to remove the type field.

Also, we changed the content field to the content-type field to make it clearer what its purpose is. The possible values for content-type field are image, video, or audio; other types of content can be added if necessary. In the future, this will allow developers a way to differentiate easily between different types of content in order to show each credit's media file correctly on the website.

Action Items

For the file _data/internal/credits/environmental-impact.yml, do the following:

Resources/Instructions

File and Code links you will need to work on this issue

@tamara-snyder tamara-snyder added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Credit https://www.hackforla.org/credits/ size: 0.5pt Can be done in 3 hours or less labels Feb 21, 2022
@github-actions

This comment was marked as outdated.

@JessicaLucindaCheng JessicaLucindaCheng changed the title Edit content field and remove type field from environmental-impact.yml file Edit content field and remove type field from environmental-impact.yml credits file Feb 24, 2022
@JessicaLucindaCheng JessicaLucindaCheng added this to the y. Technical debt milestone Mar 9, 2022
@RobenusW RobenusW self-assigned this Jun 26, 2022
@github-actions
Copy link

Hi @RobenusW, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@RobenusW
Copy link

RobenusW commented Jun 26, 2022

Availability: Tuesday-Thursday, Sunday
ETA: Sunday, July 3rd

@RobenusW
Copy link

How many hours did it take you to finish the pre-work up to and including adding your initial ETA and availability for your good first issue, including attending your first meetings?

About 3 weeks

@github-actions github-actions bot added Status: Updated No blockers and update is ready for review and removed Status: Updated No blockers and update is ready for review labels Jul 1, 2022
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

@RobenusW

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, July 5, 2022 at 12:19 AM PST.

@github-actions github-actions bot added the 2 weeks inactive An issue that has not been updated by an assignee for two weeks label Jul 8, 2022
@RobenusW
Copy link

Progress: I am a little behind
Blockers: "Difficulty making edits, because when typing on VSCODE the edits dont showup on my branch
Availability: 1 and half hours
ETA: Tuesday of next weeks

@RobenusW
Copy link

Sorry about the delay, I have just been busy personally, I promise to get back on track

@RobenusW RobenusW removed the 2 weeks inactive An issue that has not been updated by an assignee for two weeks label Jul 13, 2022
@RobenusW
Copy link

RobenusW commented Jul 13, 2022

Progress:Just need to check off dependencies
Blockers: Just waiting for merging
Availability: 1 and half hours
ETA: Sunday of this week, if not sooner

@ExperimentsInHonesty
Copy link
Member

@RobenusW I noticed you moved this back to new issue approval. Are you trying to unassign yourself from the issue?

@AzaniaBG
Copy link
Member

Submitted PR for this issue. I spent about an hour on this.

@github-actions github-actions bot added the Status: Updated No blockers and update is ready for review label Sep 23, 2022
@jdingeman
Copy link
Member

Moving this issue to Prioritized Backlog as changes have not been made and issue hasn't been worked on since September 2022.

@jdingeman jdingeman removed the Status: Updated No blockers and update is ready for review label Feb 8, 2023
@mademarc mademarc self-assigned this Mar 29, 2023
@github-actions
Copy link

Hi @mademarc, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@mademarc
Copy link
Member

Availability: 4/5/2023
ETA: 4/7/2023

@github-actions
Copy link

Hi @StephenTheDev1001, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@StephenTheDev1001
Copy link
Contributor

Availability: 3/30/2023
ETA: 3/30/2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
9 participants