Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust filter checkboxes and text #2123

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

blakes24
Copy link
Member

Fixes #1948

What changes did you make and why did you make them?

  • Added pointer when hovering over the label for the checkbox
  • Adjusted the alignment of checkboxes and text in the filter dropdown

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied Screen Shot 2021-08-16 at 3 44 57 PM
Visuals after changes are applied Screen Shot 2021-08-16 at 3 44 22 PM

@github-actions github-actions bot added P-Feature: Home page https://www.hackforla.org/ role: front end Tasks for front end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue Test: Update Label labels Aug 16, 2021
@github-actions
Copy link

From your project repository, check out a new branch and test the changes.

git checkout -b blakes24-filter-dropdown gh-pages
git pull https://github.com/blakes24/website.git filter-dropdown

@macho-catt macho-catt requested a review from GLRJr August 18, 2021 02:24
Copy link
Member

@macho-catt macho-catt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I like that you changed the div tags to li tags, since that makes more sense when used inside a ul tag.

I'm going to wait for a day to give others a chance to review this before I merge it.

@abuna1985 abuna1985 dismissed their stale review August 19, 2021 06:46

Canceling my requests

Copy link
Member

@abuna1985 abuna1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blakes24 Everything looks good. I agree with @macho-catt , the <li> was a smart semantic decision. Disregard my request changes above. I just referenced the Figma design and see there is no need for it. Great job!

@macho-catt macho-catt merged commit 4f6c319 into hackforla:gh-pages Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Home page https://www.hackforla.org/ role: front end Tasks for front end developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust Homepage filter dropdown checkboxes and text
3 participants