Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Homepage filter dropdown checkboxes and text #1948

Closed
2 tasks done
daniellex0 opened this issue Jul 15, 2021 · 2 comments · Fixed by #2123
Closed
2 tasks done

Adjust Homepage filter dropdown checkboxes and text #1948

daniellex0 opened this issue Jul 15, 2021 · 2 comments · Fixed by #2123
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Home page https://www.hackforla.org/ role: front end Tasks for front end developers size: missing

Comments

@daniellex0
Copy link
Member

daniellex0 commented Jul 15, 2021

Overview

Per issue #1398 , we need to adjust the homepage filter dropdown checkboxes to have better functionality/accessibility, and to have better vertical alignment

Action Items

  • In filter drop-downs, extend hover-over pointer from just the checkbox to include pointer over the text as well (sorry, screenshot won't capture this)
  • Improve alignment of checkboxes with their text (currently text is a little lower- should be evenly aligned) (see screenshot below)

Resources/Instructions

Homepage
Issue #1398

Text should be more center-aligned with the corresponding checkboxes:
Screen Shot 2021-07-15 at 11 45 38 AM

@daniellex0 daniellex0 added role: front end Tasks for front end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Home page https://www.hackforla.org/ labels Jul 15, 2021
@marcobarrera marcobarrera self-assigned this Jul 17, 2021
@Sihemgourou Sihemgourou added the Status: Updated No blockers and update is ready for review label Jul 18, 2021
@github-actions github-actions bot added Test: Update Label and removed Status: Updated No blockers and update is ready for review Test: Update Label labels Aug 4, 2021
@github-actions
Copy link

github-actions bot commented Aug 6, 2021

@marcobarrera

Please add update using this template (even if you have a pull request)

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) ask for help at a Tuesday or Sunday meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, August 3, 2021 at 7:53 AM.


Note: This comment was created as part of a GitHub Action during its trial phase. If you find this GitHub Action to be disruptive/unhelpful, or if you believe there might be a bug, please leave a comment on this issue. All feedback will be used to further improve it. Thank you for your time.

@Sihemgourou
Copy link
Contributor

Sihemgourou commented Aug 9, 2021

removing @marcobarrera assignment because no update has been made since 24 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Home page https://www.hackforla.org/ role: front end Tasks for front end developers size: missing
Projects
Development

Successfully merging a pull request may close this issue.

5 participants