Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert styles from scss to jss where possible #790

Closed
2 of 3 tasks
nclairesays opened this issue Apr 1, 2021 · 2 comments · Fixed by #1603
Closed
2 of 3 tasks

Convert styles from scss to jss where possible #790

nclairesays opened this issue Apr 1, 2021 · 2 comments · Fixed by #1603
Assignees
@heejung-hong
Labels
feature: Code Cleanup level: medium priority: Could Have refactor Release Note: Shows as System Update role: front-end Front End Developer
Milestone
Z - Continuous

Comments

@nclairesays
Copy link
Member

nclairesays commented Apr 1, 2021 •
edited by heejung-hong
Loading

Overview

Convert styles from scss to jss where possible so that we are not maintaining styles in multiple places. There has also been issues that arose from us resetting the default html elements. We should use the default ones and customize them in the components intentionally.

Action Items

  • Convert styles from scss to jss where possible

Dependency
@nclairesays nclairesays added refactor Release Note: Shows as System Update feature: Code Cleanup labels Apr 1, 2021
@nclairesays nclairesays mentioned this issue Apr 1, 2021
Closed
52 tasks
nclairesays added a commit that referenced this issue Apr 7, 2021
@nclairesays
Update styling on Privacy Policy Page to match Terms and Conditions p…
ba5ac0b 
…age #789 #790

  - Change all headings and bullets/lists back to default global styling, except for h1
  - Simplify h1 global default style so that title styles on all pages match
  - Delete unused reset.css files
nclairesays added a commit that referenced this issue Apr 7, 2021
@nclairesays
Fix NavBar style due to resetting of global list styling #789 #790
39092e1
nclairesays added a commit that referenced this issue Apr 7, 2021
@nclairesays
Update About page and TermsAndConditions so that app style is more un…
c468399 
…iform #789 #790
nclairesays added a commit that referenced this issue Apr 7, 2021
@nclairesays
Update usages of headings in calculation pages to have no margin, due…
35def90 
… to resetting of global headings #789 #790
nclairesays added a commit that referenced this issue Apr 7, 2021
@nclairesays
Fix centering of Public Comment page title #790
191f7db
nclairesays added a commit that referenced this issue Apr 7, 2021
@nclairesays
Update global h1 to be a little smaller #790
2d75021
@nclairesays nclairesays mentioned this issue Apr 7, 2021
Merged
@Akheal Akheal added role: front-end Front End Developer and removed role: missing labels Aug 6, 2021
@seenaiype seenaiype added this to the Z - Continuous milestone Feb 12, 2022
@heejung-hong heejung-hong self-assigned this Dec 28, 2023
@Biuwa
Copy link
Member

Biuwa commented Jan 17, 2024

Please provide an update:

  1. Progress(What is the current status of your project? What have you completed, and what is left to do):
  2. Blockers(Difficulties or errors encountered):
  3. Availability(How much time will you have this week to work on this issue):
  4. ETA(When do you expect this issue to be completed):
  5. Pictures (if necessary)(Add any pictures that will help illustrate what you are working on):

@heejung-hong
Copy link
Member

heejung-hong commented Jan 18, 2024 •
edited
Loading

  1. Progress: Two pull requests have been created. ProjectSpecifications and ProjectDescriptions pages no longer contains Calculation.scss CSS and has been converted to JSS CSS.
  2. Blockers: No blockers at this time
  3. Availability: Mon-Fri after 6pm.
  4. ETA: Thurs 02/01/24
  5. Pictures:

@Tomomi-K1 Tomomi-K1 mentioned this issue Feb 1, 2024
Merged
@ExperimentsInHonesty ExperimentsInHonesty moved this to On Dev - not yet pushed to Prod in P: TDM: project board Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heejung-hong heejung-hong

Labels
feature: Code Cleanup level: medium priority: Could Have refactor Release Note: Shows as System Update role: front-end Front End Developer
Projects
P: TDM: project board
Status: Released
Milestone
Z - Continuous
Development

Successfully merging a pull request may close this issue.

Converted Scss to Jss feedback page hackforla/tdm-calculator
8 participants
@entrotech @seenaiype @ExperimentsInHonesty @nclairesays @Akheal @Biuwa @mojimoh @heejung-hong