Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fix for NC selector in comparison modal #531

Merged
merged 1 commit into from
Apr 11, 2020
Merged

bug fix for NC selector in comparison modal #531

merged 1 commit into from
Apr 11, 2020

Conversation

jmensch1
Copy link
Contributor

Fixes #530

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@jmensch1 jmensch1 requested a review from adamkendis April 10, 2020 22:28
adamkendis
adamkendis approved these changes Apr 11, 2020
View reviewed changes
Copy link
Member

@adamkendis adamkendis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect

@adamkendis adamkendis merged commit 90e02c8 into dev Apr 11, 2020
@adamkendis adamkendis deleted the 530-FRONT-NCSelectionBug branch April 11, 2020 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkendis adamkendis adamkendis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comparison NC Selection - Modal shifts out of viewport on certain selections
2 participants
@jmensch1 @adamkendis