1127-nav-hoverContrast change hover to red

[ezhou0]

Fixes #1127

• Up to date with dev branch
• Branch name follows guidelines
• All PR Status checks are successful
• Peer reviewed and approved

Any questions? See the getting started guide

[KristenDLR]

Looks good to me!

[EchoProject]

@ezhou0 Please provide a screenshot of the before and after views.

[ezhou0]

Properly shows underline under the navlink of the active page.
DOES NOT show underline onclick for reports because it is a dropdown not a navlink.
REMOVED red hover and went back to default MUI button hover

[adamkendis]

LGTM!

[adamkendis]

I'll fix the build pipeline and merge this in over the weekend unless you beat me to it.

[nichhk]

My best guess ATM for the build failure is that GitHub Actions upgraded the default Node version to 16, right around the time that the build failures began.

This guess is corroborated by the fact that npm run setup (from client setup) failed when I was using Node 18, but succeeds when I use Node 12. I knew I should try using Node 12 because the first error I got when running npm run setup was:

npm ERR! code 1 npm ERR! path /Users/nich/hackforla/311-data/client/node_modules/node-sass

which points out node-sass; I checked the package.json file, and it requires a fairly old version of node-sass (see mapping from node-sass to Node versions here).

Every Action should specify to use Node 12 using setup-node. I will check if this works and create a new PR if so. We can also explore upgrading node-sass, but the former solution seems like the smallest one.

Regardless of whether that's the fix, we should make it plainly obvious what version of Node we expect to run on. We can do that by stating it in the package.json file (see stackoverflow question).

[nichhk]

#1183 merged into dev, and I merged dev back into this branch. The tests pass now, so I will merge this PR into dev.