Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated from jshint -> eslint #1930

Closed
wants to merge 3 commits into from
Closed

Migrated from jshint -> eslint #1930

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5355c4
Added initial eslint config & removed jshint
amilajack Mar 25, 2017
905c510
Autofixed all js styles, added airbnb eslint config
amilajack Mar 25, 2017
30b2eb1
Added missing gulp-rename dependency
amilajack Mar 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"extends": "eslint:recommended"
}
68 changes: 0 additions & 68 deletions .jscsrc
View file
Open in desktop

This file was deleted.

32 changes: 0 additions & 32 deletions .jshintrc
View file
Open in desktop

This file was deleted.

14 changes: 1 addition & 13 deletions gulpfile.babel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,18 +149,6 @@ gulp.task('copy:normalize', () =>
.pipe(gulp.dest(`${dirs.dist}/css`))
);

gulp.task('lint:js', () =>

This comment was marked as abuse.

Sign in to view

gulp.src([
'gulpfile.js',
`${dirs.src}/js/*.js`,
`${dirs.test}/*.js`
]).pipe(plugins().jscs())
.pipe(plugins().jshint())
.pipe(plugins().jshint.reporter('jshint-stylish'))
.pipe(plugins().jshint.reporter('fail'))
);


// ---------------------------------------------------------------------
// | Main tasks |
// ---------------------------------------------------------------------
Expand All @@ -175,7 +163,7 @@ gulp.task('archive', (done) => {

gulp.task('build', (done) => {
runSequence(
['clean', 'lint:js'],

This comment was marked as abuse.

Sign in to view

['clean'],
'copy',
done)
});
Expand Down
13 changes: 2 additions & 11 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,32 +12,22 @@
"babel-preset-es2015": "^6.18.0",
"babel-register": "^6.8.0",
"del": "^2.2.2",
"eslint": "^3.18.0",
"glob": "^7.1.1",
"gulp": "^3.9.1",
"gulp-autoprefixer": "^3.1.1",
"gulp-header": "^1.8.8",
"gulp-jscs": "^4.0.0",
"gulp-jshint": "^2.0.4",
"gulp-load-plugins": "^1.4.0",
"gulp-rename": "^1.2.2",
"gulp-replace": "^0.5.4",
"jquery": "3.2.0",
"jshint": "^2.9.4",
"jshint-stylish": "^2.2.1",
"mocha": "^3.2.0",
"node-sri": "^1.1.1",
"normalize.css": "5.0.0",
"run-sequence": "^1.2.2",
"travis-after-all": "^1.4.4"
},
"engines": {
"node": ">=0.10.0"
},
"babel": {
"presets": [
"es2015"
]
},
"h5bp-configs": {
"directories": {
"archive": "archive",
Expand All @@ -52,6 +42,7 @@
"private": true,
"scripts": {
"build": "gulp build",
"lint": "eslint .",
"test": "gulp archive && mocha --compilers js:babel-register --reporter spec --timeout 5000"
},
"version": "5.3.0"
Expand Down
2 changes: 0 additions & 2 deletions test/file_content.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
/* jshint mocha: true */

import assert from 'assert';
import fs from 'fs';
import path from 'path';
Expand Down
2 changes: 0 additions & 2 deletions test/file_existence.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
/* jshint mocha: true */

import assert from 'assert';
import fs from 'fs';
import path from 'path';
Expand Down