Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated from jshint -> eslint #1930

Closed
wants to merge 3 commits into from

Conversation

amilajack
Copy link
Contributor

@amilajack amilajack commented Mar 25, 2017

Closes #1913

  • Adds eslint support
  • Removed all remaining jshint deps
  • Conformed all existing code styles to eslint style config
  • Used Airbnb config

Copy link
Member

@roblarsen roblarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for letting this sit... but it's a big enough change-set that I had to actually take a look

@@ -149,18 +149,6 @@ gulp.task('copy:normalize', () =>
.pipe(gulp.dest(`${dirs.dist}/css`))
);

gulp.task('lint:js', () =>

This comment was marked as abuse.

@@ -175,7 +163,7 @@ gulp.task('archive', (done) => {

gulp.task('build', (done) => {
runSequence(
['clean', 'lint:js'],

This comment was marked as abuse.

@@ -1,24 +1,23 @@
// Avoid `console` errors in browsers that lack a console.
(function() {

This comment was marked as abuse.

@@ -1,24 +1,23 @@
// Avoid `console` errors in browsers that lack a console.
(function() {

This comment was marked as abuse.

.eslintrc Outdated
@@ -1,3 +1,12 @@
{
"extends": "eslint:recommended"

This comment was marked as abuse.

// should be included at the end
'css/main.css',

This comment was marked as abuse.

@roblarsen
Copy link
Member

@amilajack I finaly had time to take a look at the changes and had some issues. There's also a merge conflict since we added modernizr 3.0.

@XhmikosR XhmikosR mentioned this pull request Sep 25, 2017
9 tasks
@XhmikosR
Copy link
Member

@roblarsen: you can always fix the issues and push to @amilajack's fork if they take a long time to respond :)

@roblarsen
Copy link
Member

@XhmikosR it's been a while so I'm not actually expecting this to get updated. At some point I was going to revisit.

@roblarsen
Copy link
Member

Closing this and we'll revisit in a more orderly fashion.

@roblarsen roblarsen closed this Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants