-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated from jshint -> eslint #1930
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for letting this sit... but it's a big enough change-set that I had to actually take a look
gulpfile.babel.js
Outdated
@@ -149,18 +149,6 @@ gulp.task('copy:normalize', () => | |||
.pipe(gulp.dest(`${dirs.dist}/css`)) | |||
); | |||
|
|||
gulp.task('lint:js', () => |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
gulpfile.babel.js
Outdated
@@ -175,7 +163,7 @@ gulp.task('archive', (done) => { | |||
|
|||
gulp.task('build', (done) => { | |||
runSequence( | |||
['clean', 'lint:js'], |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
@@ -1,24 +1,23 @@ | |||
// Avoid `console` errors in browsers that lack a console. | |||
(function() { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
@@ -1,24 +1,23 @@ | |||
// Avoid `console` errors in browsers that lack a console. | |||
(function() { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
.eslintrc
Outdated
@@ -1,3 +1,12 @@ | |||
{ | |||
"extends": "eslint:recommended" |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
// should be included at the end | ||
'css/main.css', |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
@amilajack I finaly had time to take a look at the changes and had some issues. There's also a merge conflict since we added modernizr 3.0. |
@roblarsen: you can always fix the issues and push to @amilajack's fork if they take a long time to respond :) |
@XhmikosR it's been a while so I'm not actually expecting this to get updated. At some point I was going to revisit. |
Closing this and we'll revisit in a more orderly fashion. |
Closes #1913