Change Knip ignoreExportsUsedInFile to false and fix
#6721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -15.6 kB (-0.66%) Total Size: 2.35 MB
ℹ️ View Unchanged
|
| return 'per year'; | ||
| } | ||
|
|
||
| function getCustomAmountA11yHint( |
There was a problem hiding this comment.
I wonder if this would be a useful thing to dig into where it was used and potentially add to our checkout again?
There was a problem hiding this comment.
Yeah perhaps worth adding a card for (to investigate and fix if needed)?
tjmw
approved these changes
Jan 23, 2025
| @@ -132,5 +132,3 @@ export function PersonalDetails({ | |||
| </div> | |||
| ); | |||
| } | |||
|
|
|||
| export default PersonalDetails; | |||
There was a problem hiding this comment.
Weird that this was available as both a default and a named export!
There was a problem hiding this comment.
Yeah an odd one
|
Seen on PROD (merged by @andrewHEguardian 9 minutes and 39 seconds ago)
Sentry Release: support-client-side, support |
| } | ||
|
|
||
| export { PersonalDetailsGift, PersonalDetailsDigitalGift }; | ||
| export { PersonalDetailsGift }; |
There was a problem hiding this comment.
inline export perhaps here?
There was a problem hiding this comment.
ideally yes but there are a lot of those! And I used knip --fix so I didn't go back and fix
| @@ -12,8 +12,8 @@ export type { ActiveProductKey }; | |||
|
|
|||
| export const productCatalog = window.guardian.productCatalog; | |||
|
|
|||
| export type SupporterPlusVariants = 'control' | 'v1' | 'v2'; | |||
| export type ContributionVariants = 'control' | 'v1' | 'v2Annual' | 'v2Monthly'; | |||
| type SupporterPlusVariants = 'control' | 'v1' | 'v2'; | |||
There was a problem hiding this comment.
My mistake in yesterday's PR, its working :)
| @@ -8,7 +8,7 @@ module.exports = { | |||
| // ! signals that this is production code https://knip.dev/features/production-mode | |||
| entry: [...flattenedEntryPoints, 'scripts/build-ssr-content.tsx!'], | |||
| project: ['**/*.{js,jsx,ts,tsx,scss}!'], | |||
| ignoreExportsUsedInFile: true, | |||
| ignoreExportsUsedInFile: false, | |||
There was a problem hiding this comment.
Ah the reason all these exports are removed and this will pick it up going forwards?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you doing in this PR?
Changing the Knip config to not ignore unused exports if they're used within the same file. The main motivation for doing this is that there is a Knip issue where combining
ignoreExportsUsedInFile: trueandexport { foo }notation doesn't detect unused exports. This PR fixes the unnecessaryexportstatements and removes the completely unused exports (and subsequent unused code)